Fix Float32Array check

Author: louix

package/cpp/api/JsiSkColor.h

@@ -45,10 +45,7 @@ class JsiSkColor : public RNJsi::JsiHostObject {
   static SkColor fromValue(jsi::Runtime &runtime, const jsi::Value &obj) {
     const auto &object = obj.asObject(runtime);
     jsi::ArrayBuffer buffer =
-        object
-            .getProperty(runtime, jsi::PropNameID::forAscii(runtime, "buffer"))
-            .asObject(runtime)
-            .getArrayBuffer(runtime);
+        object.getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
     auto bfrPtr = reinterpret_cast<float *>(buffer.data(runtime));
     if (bfrPtr[0] > 1 || bfrPtr[1] > 1 || bfrPtr[2] > 1 || bfrPtr[3] > 1) {
       return SK_ColorBLACK;
@@ -77,22 +74,23 @@ class JsiSkColor : public RNJsi::JsiHostObject {
             runtime, SkColorSetARGB(color.a * 255, color.r, color.g, color.b));
       } else if (arguments[0].isObject()) {
         auto obj = arguments[0].getObject(runtime);
-        if (obj.isArrayBuffer(runtime)) {
-          return obj;
-        } else if (obj.isArray(runtime)) {
+        if (obj.isArray(runtime)) {
           auto array = obj.asArray(runtime);
-          double r = std::clamp(array.getValueAtIndex(runtime, 0).getNumber(),
-                                0.0, 255.0);
-          double g = std::clamp(array.getValueAtIndex(runtime, 1).getNumber(),
-                                0.0, 255.0);
-          double b = std::clamp(array.getValueAtIndex(runtime, 2).getNumber(),
-                                0.0, 255.0);
-          double a = std::clamp(array.getValueAtIndex(runtime, 3).getNumber(),
-                                0.0, 255.0);
-          return JsiSkColor::toValue(runtime, SkColorSetARGB(a, r, g, b));
+          // turn the array into a Float32Array
+          return runtime.global()
+              .getPropertyAsFunction(runtime, "Float32Array")
+              .callAsConstructor(runtime, array)
+              .getObject(runtime);
+        } else if (obj.hasProperty(runtime, "buffer") &&
+                   obj.getPropertyAsObject(runtime, "buffer")
+                       .isArrayBuffer(runtime)) {
+          return obj;
         }
       }
-      return jsi::Value::undefined();
+      throw jsi::JSError(runtime,
+                         "Skia.Color expected number, Float32Array, number[], "
+                         "or string and got: " +
+                             arguments[0].toString(runtime).utf8(runtime));
     };
   }
 };