BUG: Fix crash in Slicer Qt4 built adding virtual ctor to qSlicerWebWidgetPrivate

jcfr · jcfr · commit caf64947eb30 · 2018-02-05T04:37:46.000Z
See https://stackoverflow.com/questions/7403883/derived-class-with-non-virtual-destructor/7403943#7403943 git-svn-id: http://svn.slicer.org/Slicer4/trunk@26887 3bd1e089-480b-0410-8dfb-8563597acbee
diff --git a/Base/QTGUI/qSlicerWebWidget.cxx b/Base/QTGUI/qSlicerWebWidget.cxx
@@ -51,6 +51,11 @@ qSlicerWebWidgetPrivate::qSlicerWebWidgetPrivate(qSlicerWebWidget& object)
 {
 }
 
+// --------------------------------------------------------------------------
+qSlicerWebWidgetPrivate::~qSlicerWebWidgetPrivate()
+{
+}
+
 // --------------------------------------------------------------------------
 void qSlicerWebWidgetPrivate::init()
 {
diff --git a/Base/QTGUI/qSlicerWebWidget_p.h b/Base/QTGUI/qSlicerWebWidget_p.h
@@ -67,8 +67,9 @@ class qSlicerWebWidgetPrivate: public Ui_qSlicerWebWidget
 
 public:
   qSlicerWebWidgetPrivate(qSlicerWebWidget& object);
+  virtual ~qSlicerWebWidgetPrivate();
 
-  void init();
+  virtual void init();
 
 #if (QT_VERSION < QT_VERSION_CHECK(5, 6, 0))
   /// Convenient function to return the mainframe

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,11 @@ qSlicerWebWidgetPrivate::qSlicerWebWidgetPrivate(qSlicerWebWidget& object)`
`51`	`51`	`{`
`52`	`52`	`}`
`53`	`53`
	`54`	`+// --------------------------------------------------------------------------`
	`55`	`+qSlicerWebWidgetPrivate::~qSlicerWebWidgetPrivate()`
	`56`	`+{`
	`57`	`+}`
	`58`	`+`
`54`	`59`	`// --------------------------------------------------------------------------`
`55`	`60`	`void qSlicerWebWidgetPrivate::init()`
`56`	`61`	`{`