MA-946 #time 20m updated test comments and updated SparkPost default

hostname

Author: beardyman

examples/transmission/configuration_based.php

@@ -24,8 +24,6 @@
     	]
 	]);
 	echo 'Congrats you can use your SDK!';
-	
-	var_dump(Transmission::$structure);
 } catch (\Exception $exception) {
 	echo $exception->getMessage();
 }

lib/MessageSystems/SparkPost.php

@@ -5,7 +5,7 @@ class SparkPost {
 
 	private static $config;
 	private static $defaults = [
-			'host'=>'app.cloudplaceholder.com',
+			'host'=>'api.sparkpost.com',
 			'protocol'=>'https',
 			'port'=>443,
 			'strictSSL'=>true,

test/unit/SparkPostTest.php

@@ -7,7 +7,6 @@ class SparkPostTest extends \PHPUnit_Framework_TestCase {
 
 	/**
 	 * @desc Ensures that the configuration class is not instantiable.
-	 * @covers SparkPost::__construct
 	 */
 	public function testConstructorCannotBeCalled() {
 		$class = new \ReflectionClass('\MessageSystems\SparkPost');
@@ -17,7 +16,6 @@ public function testConstructorCannotBeCalled() {
 	/**
 	 * @desc Tests that an exception is thrown when a library tries to recieve the config and it has not yet been set.
 	 * 		Since its a singleton this test must come before any setConfig tests.
-	 * @covers SparkPost::getConfig
 	 * @expectedException Exception
 	 * @expectedExceptionMessage No configuration has been provided
 	 */
@@ -27,7 +25,6 @@ public function testGetConfigEmptyException() {
 
 	/**
 	 * @desc Tests that the api key is set when setting the config
-	 * @covers SparkPost::setConfig
 	 * @expectedException Exception
 	 * @expectedExceptionMessage You must provide an API key
 	 */
@@ -37,7 +34,6 @@ public function testSetConfigAPIKeyNotSetException() {
 
 	/**
 	 * @desc Tests that the api key is set when setting the config and that its not empty
-	 * @covers SparkPost::setConfig
 	 * @expectedException Exception
 	 * @expectedExceptionMessage You must provide an API key
 	 */
@@ -47,7 +43,6 @@ public function testSetConfigAPIKeyEmptyException() {
 
 	/**
 	 * @desc Tests overridable values are set while invalid values are ignored
-	 * @covers SparkPost::setConfig
 	 */
 	public function testSetConfigMultipleValuesAndGetConfig() {
 		SparkPost::setConfig(['key'=>'lala', 'version'=>'v8', 'port'=>1024, 'someOtherValue'=>'fakeValue']);
@@ -58,7 +53,7 @@ public function testSetConfigMultipleValuesAndGetConfig() {
 		$this->assertEquals(1024, $testConfig['port']);
 		$this->assertNotContains('someOtherValue', array_keys($testConfig));
 		$this->assertEquals('https', $testConfig['protocol']);
-		$this->assertEquals('app.cloudplaceholder.com', $testConfig['host']);
+		$this->assertEquals('api.sparkpost.com', $testConfig['host']);
 		$this->assertEquals(true, $testConfig['strictSSL']);
 	}
 }

test/unit/TransmissionTest.php

@@ -39,7 +39,6 @@ public function setUp() {
 
 	/**
 	 * @desc Ensures that the configuration class is not instantiable.
-	 * @covers Transmission::__construct
 	 */
 	public function testConstructorCannotBeCalled() {
 		$class = new \ReflectionClass('\MessageSystems\Transmission');
@@ -48,7 +47,6 @@ public function testConstructorCannotBeCalled() {
 
 	/**
 	 * @desc tests happy path
-	 * @covers Transmission::all
 	 */
 	public function testAllWithGoodResponse() {
 		$mock = new Mock([new Response(200, [], Stream::factory('{"results":[{"test":"This is a test"}, {"test":"two"}]}'))]);
@@ -59,7 +57,6 @@ public function testAllWithGoodResponse() {
 
 	/**
 	 * @desc tests happy path
-	 * @covers Transmission::find
 	 */
 	public function testFindWithGoodResponse() {
 		$mock = new Mock([new Response(200, [], Stream::factory('{"results":[{"test":"This is a test"}]}'))]);
@@ -70,7 +67,6 @@ public function testFindWithGoodResponse() {
 
 	/**
 	 * @desc tests 404 bad response
-	 * @covers Transmission::find
 	 */
 	public function testFindWith404Response() {
 		$mock = new Mock([new Response(404, [])]);
@@ -86,7 +82,6 @@ public function testFindWith404Response() {
 
 	/**
 	 * @desc tests unknown bad response
-	 * @covers Transmission::find
 	 */
 	public function testFindWithOtherBadResponse() {
 		$mock = new Mock([new Response(400, [])]);
@@ -102,7 +97,6 @@ public function testFindWithOtherBadResponse() {
 
 	/**
 	 * @desc tests happy path
-	 * @covers Transmission::send
 	 */
 	public function testSuccessfulSend() {
 		$body = ["result"=>["transmission_id"=> "11668787484950529"], "status"=>["message"=> "ok","code"=> "1000"]];
@@ -114,7 +108,6 @@ public function testSuccessfulSend() {
 
 	/**
 	 * @desc tests bad response
-	 * @covers Transmission::send
 	 */
 	public function testSendForRequestException() {
 		$body = ['errors'=>['This is a fake error']];