Skip to content

Commit 1295c7e

Browse files
authored
Merge pull request #3482 from zm711/basesorter
Remove Non-Serializable writing of json
2 parents 0baf7e0 + af1709a commit 1295c7e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/spikeinterface/sorters/basesorter.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,10 @@ def initialize_folder(cls, recording, output_folder, verbose, remove_existing_fo
145145
elif recording.check_serializability("pickle"):
146146
recording.dump(output_folder / "spikeinterface_recording.pickle", relative_to=output_folder)
147147
else:
148-
# TODO: deprecate and finally remove this after 0.100
149-
d = {"warning": "The recording is not serializable to json"}
150-
rec_file.write_text(json.dumps(d, indent=4), encoding="utf8")
148+
raise RuntimeError(
149+
"This recording is not serializable and so can not be sorted. Consider `recording.save()` to save a "
150+
"compatible binary file."
151+
)
151152

152153
return output_folder
153154

0 commit comments

Comments
 (0)