Merge pull request #3455 from samuelgarcia/fix_warning_qm

Avoid warnings in sorting analyzer

Author: alejoe91

src/spikeinterface/core/sortinganalyzer.py

@@ -1976,7 +1976,8 @@ def load_data(self):
                     continue
                 ext_data_name = ext_data_file.stem
                 if ext_data_file.suffix == ".json":
-                    ext_data = json.load(ext_data_file.open("r"))
+                    with ext_data_file.open("r") as f:
+                        ext_data = json.load(f)
                 elif ext_data_file.suffix == ".npy":
                     # The lazy loading of an extension is complicated because if we compute again
                     # and have a link to the old buffer on windows then it fails
@@ -1988,7 +1989,8 @@ def load_data(self):
 
                     ext_data = pd.read_csv(ext_data_file, index_col=0)
                 elif ext_data_file.suffix == ".pkl":
-                    ext_data = pickle.load(ext_data_file.open("rb"))
+                    with ext_data_file.open("rb") as f:
+                        ext_data = pickle.load(f)
                 else:
                     continue
                 self.data[ext_data_name] = ext_data

src/spikeinterface/qualitymetrics/quality_metric_calculator.py

@@ -234,7 +234,8 @@ def _run(self, verbose=False, **job_kwargs):
         )
 
         existing_metrics = []
-        qm_extension = self.sorting_analyzer.get_extension("quality_metrics")
+        # here we get in the loaded via the dict only (to avoid full loading from disk after params reset)
+        qm_extension = self.sorting_analyzer.extensions.get("quality_metrics", None)
         if (
             delete_existing_metrics is False
             and qm_extension is not None