Skip to content

Commit 5842dfd

Browse files
authored
Merge pull request #70 from SumoLogic/SUMO-233810-minor-changes
check_function message updates
2 parents f095ff5 + f17758d commit 5842dfd

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

EventHubs/tests/baseeventhubtest.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ def fetchlogs(self, app_insights):
100100
row_dict = {str(col): str(item) for col, item in zip(table.columns, row)}
101101
result.append(row_dict)
102102
except Exception as e:
103-
print("An unexpected error occurred during the test:")
104103
print("Exception", e)
105104

106105
return result
@@ -129,10 +128,11 @@ def check_resource_count(self):
129128
self.assertTrue(resource_count == self.expected_resource_count, f"resource count of resource group {self.RESOURCE_GROUP_NAME} differs from expected count : {resource_count}")
130129

131130
def check_success_log(self, logs):
132-
self.assertTrue(self.filter_logs(logs, 'message', self.successful_sent_message))
131+
self.assertTrue(self.filter_logs(logs, 'message', self.successful_sent_message), "No success message found in azure function logs")
133132

134133
def check_error_log(self, logs):
135-
self.assertTrue(not self.filter_logs(logs, 'severityLevel', '3'))
134+
self.assertFalse(self.filter_logs(logs, 'severityLevel', '3'), "Error messages found in azure function logs")
136135

137136
def check_warning_log(self, logs):
138-
self.assertTrue(not self.filter_logs(logs, 'severityLevel', '2'))
137+
self.assertFalse(self.filter_logs(logs, 'severityLevel', '2'), "Warning messages found in azure function logs")
138+

EventHubs/tests/test_eventhub_logs.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,14 @@ def setUp(self):
1616
self.template_name = 'azuredeploy_logs.json'
1717
self.event_hub_namespace_prefix = "SumoAzureLogsNamespace"
1818
self.eventhub_name = 'insights-operational-logs'
19+
self.successful_sent_message = 'Sent all data to Sumo. Exit now.'
20+
self.expected_resource_count = 7
1921

2022
def test_pipeline(self):
2123
self.create_resource_group()
2224
self.deploy_template()
2325
print("Testing Stack Creation")
2426
self.assertTrue(self.resource_group_exists(self.RESOURCE_GROUP_NAME))
25-
self.table_service = self.get_table_service()
2627
self.insert_mock_logs_in_EventHub('activity_log_fixtures.json')
2728

2829
def insert_mock_logs_in_EventHub(self, filename):
@@ -38,8 +39,6 @@ def insert_mock_logs_in_EventHub(self, filename):
3839
# print("inserting %s" % (mock_logs))
3940
self.send_event_data_list(self.event_hub_namespace_prefix, self.eventhub_name, event_data_list)
4041

41-
print("Event inserted")
42-
4342

4443
if __name__ == '__main__':
4544
unittest.main()

0 commit comments

Comments
 (0)