fix(form-core): preserve leading zeros in numeric string field names (#1620)

Author: kusiewicz

packages/form-core/src/utils.ts

@@ -171,8 +171,14 @@ export function makePathArray(str: string | Array<string | number>) {
       .replace(reMultipleDots, '.')
       .split('.')
       .map((d) => {
-        if (d.indexOf(intPrefix) === 0) {
-          return parseInt(d.substring(intPrefix.length), 10)
+        if (d.startsWith(intPrefix)) {
+          const numStr = d.substring(intPrefix.length)
+          const num = parseInt(numStr, 10)
+
+          if (String(num) === numStr) {
+            return num
+          }
+          return numStr
         }
         return d
       })

packages/form-core/tests/utils.spec.ts

@@ -133,6 +133,16 @@ describe('setBy', () => {
       ],
     ])
   })
+
+  it('should correctly set a value on a key with leading zeros', () => {
+    const initial = { name: 'test' }
+    const result = setBy(initial, '01234', 'some-value')
+
+    expect(result).toHaveProperty('01234')
+    expect(result['01234']).toBe('some-value')
+
+    expect(result).not.toHaveProperty('1234')
+  })
 })
 
 describe('deleteBy', () => {
@@ -223,6 +233,15 @@ describe('makePathArray', () => {
     expect(makePathArray('[2][3].a')).toEqual([2, 3, 'a'])
     expect(makePathArray('[4][5][6].b[7]')).toEqual([4, 5, 6, 'b', 7])
   })
+
+  it('should preserve leading zeros on purely numeric strings', () => {
+    expect(makePathArray('01234')).toEqual(['01234'])
+    expect(makePathArray('007')).toEqual(['007'])
+  })
+
+  it('should still convert non-leading-zero numbers to number types', () => {
+    expect(makePathArray('12345')).toEqual([12345])
+  })
 })
 
 describe('determineFormLevelErrorSourceAndValue', () => {