refactor(security): remove redundant comments and debug logs

Author: bobtista

Generals/Code/GameEngine/Source/GameNetwork/ConnectionManager.cpp

@@ -53,13 +53,6 @@
 #include "GameClient/DisconnectMenu.h"
 #include "GameClient/InGameUI.h"
 
-//============================================================================
-// hasValidTransferFileExtension
-//============================================================================
-// TheSuperHackers @security bobtista 06/11/2025
-// Validates file extensions for map transfer operations to prevent arbitrary
-// file types from being transferred over the network or loaded from save games.
-//============================================================================
 static Bool hasValidTransferFileExtension(const AsciiString& filePath)
 {
 	static const char* const validExtensions[] = {
@@ -75,7 +68,6 @@ static Bool hasValidTransferFileExtension(const AsciiString& filePath)
 
 	if (fileExt == NULL || fileExt[1] == '\0')
 	{
-		DEBUG_LOG(("File path '%s' has no extension.", filePath.str()));
 		return false;
 	}
 
@@ -89,7 +81,6 @@ static Bool hasValidTransferFileExtension(const AsciiString& filePath)
 		}
 	}
 
-	DEBUG_LOG(("File path '%s' has invalid extension '%s' for transfer operations.", filePath.str(), fileExt));
 	return false;
 }
 

GeneralsMD/Code/GameEngine/Source/GameNetwork/ConnectionManager.cpp

@@ -53,13 +53,6 @@
 #include "GameClient/DisconnectMenu.h"
 #include "GameClient/InGameUI.h"
 
-//============================================================================
-// hasValidTransferFileExtension
-//============================================================================
-// TheSuperHackers @security bobtista 06/11/2025
-// Validates file extensions for map transfer operations to prevent arbitrary
-// file types from being transferred over the network or loaded from save games.
-//============================================================================
 static Bool hasValidTransferFileExtension(const AsciiString& filePath)
 {
 	static const char* const validExtensions[] = {
@@ -75,7 +68,6 @@ static Bool hasValidTransferFileExtension(const AsciiString& filePath)
 
 	if (fileExt == NULL || fileExt[1] == '\0')
 	{
-		DEBUG_LOG(("File path '%s' has no extension.", filePath.str()));
 		return false;
 	}
 
@@ -89,7 +81,6 @@ static Bool hasValidTransferFileExtension(const AsciiString& filePath)
 		}
 	}
 
-	DEBUG_LOG(("File path '%s' has invalid extension '%s' for transfer operations.", filePath.str(), fileExt));
 	return false;
 }