feat: move substring of label into config record

Author: christolis

application/config.json.template

@@ -117,7 +117,7 @@
     },
     "roleApplicationSystem": {
         "submissionsChannelPattern": "staff-applications",
-        "defaultQuestion": "What makes you a valuable addition to the team? 😎",
+        "defaultQuestion": "What makes you a good addition to the team?",
         "minimumAnswerLength": 50,
         "maximumAnswerLength": 500,
         "applicationSubmitCooldownMinutes": 5

application/src/main/java/org/togetherjava/tjbot/config/RoleApplicationSystemConfig.java

@@ -1,6 +1,7 @@
 package org.togetherjava.tjbot.config;
 
 import com.fasterxml.jackson.annotation.JsonProperty;
+import net.dv8tion.jda.api.interactions.components.text.TextInput;
 
 import java.util.Objects;
 
@@ -26,5 +27,9 @@ public record RoleApplicationSystemConfig(
     public RoleApplicationSystemConfig {
         Objects.requireNonNull(submissionsChannelPattern);
         Objects.requireNonNull(defaultQuestion);
+
+        if (defaultQuestion.length() > TextInput.MAX_LABEL_LENGTH) {
+            throw new IllegalArgumentException("defaultQuestion length is too long! Cannot be greater than %d".formatted(TextInput.MAX_LABEL_LENGTH));
+        }
     }
 }

application/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationCreateCommand.java

@@ -134,13 +134,8 @@ public void onStringSelectSelection(StringSelectInteractionEvent event, List<Str
             return;
         }
 
-        String questionLabel = roleApplicationSystemConfig.defaultQuestion();
-        if (questionLabel.length() > TextInput.MAX_LABEL_LENGTH) {
-            questionLabel = questionLabel.substring(0, TextInput.MAX_LABEL_LENGTH);
-        }
-
         TextInput body = TextInput
-            .create(generateComponentId(event.getUser().getId()), questionLabel,
+            .create(generateComponentId(event.getUser().getId()), roleApplicationSystemConfig.defaultQuestion(),
                     TextInputStyle.PARAGRAPH)
             .setRequired(true)
             .setRequiredRange(roleApplicationSystemConfig.minimumAnswerLength(),