generateRoleOptions: remove unnecessary parameter

As it currently is, the helper method `generateRoleOptions` takes one
`SlashCommandData` parameter and is used once throughout the entire
project, specifically in the same class it is defined.

In that one case, `generateRoleOptions` would take in `getData()` as its
input, a method that is accessible through the entire class due to the
simple fact that `CreateRoleApplicationCommand` inherits methods from
`SlashCommandAdapter`.

Modify the `generateRoleOptions` helper method to take no input and
inside it, store a reference of `getData()` for the method to make use
of.

Suggested-by: Zabuzard <zabuza.dev@gmail.com>
Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

Author: christolis

application/src/main/java/org/togetherjava/tjbot/features/roleapplication/CreateRoleApplicationCommand.java

@@ -66,16 +66,17 @@ public CreateRoleApplicationCommand(Config config) {
 
         this.config = config.getRoleApplicationSystemConfig();
 
-        generateRoleOptions(getData());
+        generateRoleOptions();
         handler = new RoleApplicationHandler(this.config);
     }
 
     /**
-     * Populates a {@link SlashCommandData} object with the proper arguments.
-     *
-     * @param data the object to populate
+     * Populates this command's instance {@link SlashCommandData} object with the proper arguments
+     * for this command.
      */
-    private void generateRoleOptions(SlashCommandData data) {
+    private void generateRoleOptions() {
+        final SlashCommandData data = getData();
+
         IntStream.range(1, OPTIONAL_ROLES_AMOUNT + 1).forEach(index -> {
             data.addOption(OptionType.STRING, generateOptionId("title", index),
                     "The title of the role");