Merge pull request #19 from Tynamix/ENHANCE_RandomListPlugin

Improved the random list plugin a lot!

Author: Tynamix

ObjectFiller.Test/ObjectFillerTest.cs

@@ -19,12 +19,14 @@ public void TestFillPerson()
                 .OnType<IAddress>().CreateInstanceOf<Address>()
                 .OnType<string>().Use(new MnemonicString(10))
                 .OnProperty(person => person.FirstName).Use(new MnemonicString(1))
-                .OnProperty(person => person.LastName).Use(new RandomListItem<string>(new List<string>() { "Maik", "Tom", "Anton" }))
+                .OnProperty(person => person.LastName).Use(new RandomListItem<string>("Maik", "Tom", "Anton"))
                 .OnProperty(person => person.Age).Use(() => new Random().Next(12, 83))
                 .SetupFor<Address>()
                 .OnProperty(x => x.City, x => x.Country).IgnoreIt();
 
             Person pFilled = filler.Fill(p);
+
+            Assert.IsTrue(new List<string>() { "Maik", "Tom", "Anton" }.Contains(pFilled.LastName));
         }
 
         [TestMethod]

ObjectFiller/Plugins/RandomListItem.cs

@@ -1,28 +1,35 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Linq;
 
 namespace Tynamix.ObjectFiller
 {
     public class RandomListItem<T> : IRandomizerPlugin<T>
     {
-        private readonly List<T> _allAvailableValues;
+        private readonly T[] _allAvailableValues;
 
-        public RandomListItem(List<T> allAvailableValues)
+        public RandomListItem(params T[] allAvailableValues)
         {
-            if (allAvailableValues == null || allAvailableValues.Count == 0)
+            if (allAvailableValues == null || allAvailableValues.Length == 0)
             {
-	            const string message = "List in RandomListItem ranomizer can not be empty!";
-				Debug.WriteLine("ObjectFiller: " + message);
-				throw new ArgumentException(message);
+                const string message = "List in RandomListItem ranomizer can not be empty!";
+                Debug.WriteLine("ObjectFiller: " + message);
+                throw new ArgumentException(message);
             }
-	        _allAvailableValues = allAvailableValues;
+            _allAvailableValues = allAvailableValues;
+        }
+
+        public RandomListItem(IEnumerable<T> allAvailableValues)
+            : this(allAvailableValues.ToArray())
+        {
 
         }
 
+
         public T GetValue()
         {
-            int rndmListIndex = Random.Next(0, _allAvailableValues.Count);
+            int rndmListIndex = Random.Next(0, _allAvailableValues.Length - 1);
             return _allAvailableValues[rndmListIndex];
         }
     }