Fixed e2e tests

Author: matthewlipski

packages/core/src/extensions/FormattingToolbar/FormattingToolbar.ts

@@ -1,8 +1,9 @@
+import { NodeSelection, TextSelection } from "prosemirror-state";
+
 import {
   createExtension,
   createStore,
 } from "../../editor/BlockNoteExtension.js";
-import { TextSelection } from "prosemirror-state";
 
 export const FormattingToolbarExtension = createExtension(({ editor }) => {
   const store = createStore(false);
@@ -15,6 +16,15 @@ export const FormattingToolbarExtension = createExtension(({ editor }) => {
         return false;
       }
 
+      // Don't show if a block with inline content is selected.
+      if (
+        tr.selection instanceof NodeSelection &&
+        (tr.selection.node.type.spec.content === "inline*" ||
+          tr.selection.node.firstChild?.type.spec.content === "inline*")
+      ) {
+        return false;
+      }
+
       // Don't show if the selection is a text selection but contains no text.
       if (
         tr.selection instanceof TextSelection &&

tests/package.json

@@ -5,9 +5,9 @@
   "scripts": {
     "build": "tsc",
     "lint": "eslint src --max-warnings 0",
-    "playwright": "playwright test",
+    "playwright": "playwright test dragdrop --headed",
     "test": "vitest --run",
-    "test:updateSnaps": "docker run --rm -e RUN_IN_DOCKER=true --network host -v $(pwd)/..:/work/ -w /work/tests -it mcr.microsoft.com/playwright:v1.51.1-noble npx playwright test -u",
+    "test:updateSnaps": "docker run --rm -e RUN_IN_DOCKER=true --network host -v $(pwd)/..:/work/ -w /work/tests -it mcr.microsoft.com/playwright:v1.51.1-noble npx playwright test dragdrop -u",
     "test-ct": "playwright test -c playwright-ct.config.ts --headed",
     "test-ct:updateSnaps": "docker run --rm  -e RUN_IN_DOCKER=true --network host -v $(pwd)/..:/work/ -w /work/tests -it mcr.microsoft.com/playwright:v1.51.1-noble npx playwright test -c playwright-ct.config.ts -u",
     "clean": "rimraf dist"

tests/src/end-to-end/dragdrop/dragdrop.test.ts-snapshots/dragdropnested-chromium-linux.json

@@ -7,7 +7,7 @@
         {
           "type": "blockContainer",
           "attrs": {
-            "id": "1"
+            "id": "2"
           },
           "content": [
             {
@@ -54,7 +54,7 @@
                 {
                   "type": "blockContainer",
                   "attrs": {
-                    "id": "3"
+                    "id": "5"
                   },
                   "content": [
                     {
@@ -77,7 +77,7 @@
                         {
                           "type": "blockContainer",
                           "attrs": {
-                            "id": "2"
+                            "id": "4"
                           },
                           "content": [
                             {
@@ -109,7 +109,7 @@
         {
           "type": "blockContainer",
           "attrs": {
-            "id": "4"
+            "id": "6"
           },
           "content": [
             {
@@ -133,7 +133,7 @@
         {
           "type": "blockContainer",
           "attrs": {
-            "id": "5"
+            "id": "7"
           },
           "content": [
             {

tests/src/end-to-end/dragdrop/dragdrop.test.ts-snapshots/dragdropnested-webkit-linux.json

@@ -7,7 +7,7 @@
         {
           "type": "blockContainer",
           "attrs": {
-            "id": "1"
+            "id": "2"
           },
           "content": [
             {
@@ -54,7 +54,7 @@
                 {
                   "type": "blockContainer",
                   "attrs": {
-                    "id": "3"
+                    "id": "5"
                   },
                   "content": [
                     {
@@ -77,7 +77,7 @@
                         {
                           "type": "blockContainer",
                           "attrs": {
-                            "id": "2"
+                            "id": "4"
                           },
                           "content": [
                             {
@@ -109,7 +109,7 @@
         {
           "type": "blockContainer",
           "attrs": {
-            "id": "4"
+            "id": "6"
           },
           "content": [
             {
@@ -133,7 +133,7 @@
         {
           "type": "blockContainer",
           "attrs": {
-            "id": "5"
+            "id": "7"
           },
           "content": [
             {

tests/src/utils/mouse.ts

@@ -39,14 +39,17 @@ export async function dragAndDropBlock(
   dropAbove: boolean,
 ) {
   await moveMouseOverElement(page, dragTarget);
+  await page.waitForTimeout(100);
 
   await page.waitForSelector(DRAG_HANDLE_SELECTOR);
   const dragHandle = await page.locator(DRAG_HANDLE_SELECTOR);
   const dragHandleCenterCoords = await getElementCenterCoords(page, dragHandle);
   await page.mouse.move(dragHandleCenterCoords.x, dragHandleCenterCoords.y, {
     steps: 5,
   });
+  await page.waitForTimeout(100);
   await page.mouse.down();
+  await page.waitForTimeout(100);
 
   const dropTargetCoords = dropAbove
     ? await getElementLeftCoords(page, dropTarget)