Cleaned up SyncVar system slightly

Author: TwoTenPvP

MLAPI/MonoBehaviours/Core/NetworkedBehaviour.cs

@@ -84,7 +84,7 @@ private void OnEnable()
             {
                 _networkedObject = GetComponentInParent<NetworkedObject>();
             }
-            NetworkedObject.networkedBehaviours.Add(this);
+            NetworkedObject.NetworkedBehaviours.Add(this);
         }
 
         internal bool networkedStartInvoked = false;
@@ -117,7 +117,7 @@ protected void DeregisterMessageHandler(string name, int counter)
 
         private void OnDisable()
         {
-            NetworkedObject.networkedBehaviours.Remove(this);
+            NetworkedObject.NetworkedBehaviours.Remove(this);
         }
 
         private void OnDestroy()
@@ -237,16 +237,12 @@ internal void SyncVarInit()
 
         internal void OnSyncVarUpdate(object value, byte fieldIndex)
         {
-            if (isServer)
-                return;
             syncedFields[fieldIndex].SetValue(this, value);
         }
 
         private float lastSyncTime = 0f;
-        internal void SyncvarUpdate()
+        internal void SyncVarUpdate()
         {
-            if (!isServer)
-                return;
             SetDirtyness();
             if(Time.time - lastSyncTime >= SyncVarSyncDelay)
             {

MLAPI/MonoBehaviours/Core/NetworkedObject.cs

@@ -97,17 +97,18 @@ internal void InvokeBehaviourNetworkSpawn()
                 if(netBehaviours[i].networkedObject == this && !netBehaviours[i].networkedStartInvoked)
                 {
                     netBehaviours[i].NetworkStart();
-                    netBehaviours[i].SyncVarInit();
+                    if (NetworkingManager.singleton.isServer)
+                        netBehaviours[i].SyncVarInit();
                 }
             }
         }
 
-        internal static List<NetworkedBehaviour> networkedBehaviours = new List<NetworkedBehaviour>();
+        internal static List<NetworkedBehaviour> NetworkedBehaviours = new List<NetworkedBehaviour>();
         internal static void InvokeSyncvarUpdate()
         {
-            for (int i = 0; i < networkedBehaviours.Count; i++)
+            for (int i = 0; i < NetworkedBehaviours.Count; i++)
             {
-                networkedBehaviours[i].SyncvarUpdate();
+                NetworkedBehaviours[i].SyncVarUpdate();
             }
         }
 

MLAPI/MonoBehaviours/Core/NetworkingManager.cs

@@ -363,9 +363,10 @@ private void Update()
 
             }
             if (isServer)
+            {
                 LagCompensationManager.AddFrames();
-
-            NetworkedObject.InvokeSyncvarUpdate();
+                NetworkedObject.InvokeSyncvarUpdate();
+            }
         }
 
         private IEnumerator ApprovalTimeout(int clientId)