Handle disambiguation with universal target type

Author: kraigher

vhdl_lang/src/analysis/expression.rs

@@ -1601,4 +1601,31 @@ function \"+\"(a : integer; b : character) return integer;
             ))
         );
     }
+
+    #[test]
+    fn universal_integer_target_type_accepts_integer() {
+        let test = TestSetup::new();
+        test.declarative_part(
+            "
+function no_arg return boolean;
+function no_arg return integer;
+function with_arg(arg : natural) return boolean;
+function with_arg(arg : natural) return integer;
+
+        ",
+        );
+
+        let code = test.snippet("no_arg");
+        test.expr_with_ttyp(
+            &code,
+            test.ctx().universal_integer().into(),
+            &mut NoDiagnostics,
+        );
+        let code = test.snippet("with_arg(0)");
+        test.expr_with_ttyp(
+            &code,
+            test.ctx().universal_integer().into(),
+            &mut NoDiagnostics,
+        );
+    }
 }

vhdl_lang/src/analysis/overloaded.rs

@@ -319,7 +319,7 @@ impl<'a> AnalyzeContext<'a> {
 
         let ok_return_type = if let SubprogramKind::Function(rtyp) = kind {
             let mut ok_return_type = ok_assoc_types.clone();
-            self.implicit_matcher()
+            self.any_matcher()
                 .disambiguate_op_by_return_type(&mut ok_return_type, rtyp);
 
             // Only one candidate matches type profile, check it