Skip to content

Commit b1c26a8

Browse files
authored
Merge pull request #19
Correct the expiry date comparison for ce_values and pe_values
2 parents cf92380 + 949f814 commit b1c26a8

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

NSE_Option_Chain_Analyzer.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,19 +1076,18 @@ def get_dataframe(self) -> Optional[Tuple[pandas.DataFrame, str, float]]:
10761076
df = df.transpose()
10771077

10781078
ce_values: List[dict] = [data['CE'] for data in json_data['records']['data'] if
1079-
"CE" in data and str(data['expiryDate'].lower() == str(self.expiry_date).lower())]
1079+
"CE" in data and str(data['expiryDate']).lower() == str(self.expiry_date).lower()]
10801080
pe_values: List[dict] = [data['PE'] for data in json_data['records']['data'] if
1081-
"PE" in data and str(data['expiryDate'].lower() == str(self.expiry_date).lower())]
1081+
"PE" in data and str(data['expiryDate']).lower() == str(self.expiry_date).lower()]
10821082
points: float = pe_values[0]['underlyingValue']
10831083
if points == 0:
10841084
for item in pe_values:
10851085
if item['underlyingValue'] != 0:
10861086
points = item['underlyingValue']
10871087
break
1088-
ce_data: pandas.DataFrame = pandas.DataFrame(ce_values)
1089-
pe_data: pandas.DataFrame = pandas.DataFrame(pe_values)
1090-
ce_data_f: pandas.DataFrame = ce_data.loc[ce_data['expiryDate'] == self.expiry_date]
1091-
pe_data_f: pandas.DataFrame = pe_data.loc[pe_data['expiryDate'] == self.expiry_date]
1088+
ce_data_f: pandas.DataFrame = pandas.DataFrame(ce_values)
1089+
pe_data_f: pandas.DataFrame = pandas.DataFrame(pe_values)
1090+
10921091
if ce_data_f.empty:
10931092
messagebox.showerror(title="Error",
10941093
message="Invalid Expiry Date.\nPlease restart and enter a new Expiry Date.")

0 commit comments

Comments
 (0)