Skip to content

Commit bd1a157

Browse files
bdashplafosse
authored andcommitted
[KernelCache] Remove 'Load Selected Image and Dependencies'
Fixes #7615. The dependency loading for kernel cache images was copied from the shared cache code, and looks for `LC_LOAD_DYLIB` load commands to determine the direct dependencies of an image. Images in kernel caches don't use `LC_LOAD_DYLIB` load commands so no dependencies were ever loaded. It could, however, result in a crash.
1 parent 0cb2082 commit bd1a157

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

view/kernelcache/ui/kctriage.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@ QWidget* KCTriageView::initImageTable()
208208

209209
QAction noSelectionAction("No Images Selected", m_imageTable);
210210
QAction loadImagesAction("", m_imageTable);
211-
QAction loadImagesWithDepsAction("", m_imageTable);
212211
if (selectedCount == 0)
213212
{
214213
noSelectionAction.setEnabled(false);
@@ -223,14 +222,6 @@ QWidget* KCTriageView::initImageTable()
223222
loadImagesWithAddr(addresses, false);
224223
});
225224
contextMenu.addAction(&loadImagesAction);
226-
227-
// Format action text for loading selected images with dependencies
228-
QString loadWithDepsActionText = (selectedCount == 1) ? "Load Selected Image and Dependencies" : QString("Load %1 Selected Images and Dependencies").arg(selectedCount);
229-
loadImagesWithDepsAction.setText(loadWithDepsActionText);
230-
connect(&loadImagesWithDepsAction, &QAction::triggered, [this, addresses]() {
231-
this->loadImagesWithAddr(addresses, true);
232-
});
233-
contextMenu.addAction(&loadImagesWithDepsAction);
234225
}
235226

236227
contextMenu.exec(m_imageTable->viewport()->mapToGlobal(pos));

0 commit comments

Comments
 (0)