🐛 Fix Unused

Author: VincentLanglet

SymfonyCustom/Sniffs/Formatting/ConditionalReturnOrThrowSniff.php

@@ -29,9 +29,10 @@ public function process(File $phpcsFile, $stackPtr): void
         $tokens = $phpcsFile->getTokens();
         $opener = $phpcsFile->findPrevious([T_IF, T_CASE], $stackPtr);
 
-        if ($opener
+        if (false !== $opener
             && isset($tokens[$opener]['scope_closer'])
-            && $stackPtr <= $tokens[$opener]['scope_closer']) {
+            && $stackPtr <= $tokens[$opener]['scope_closer']
+        ) {
             $isClosure = $phpcsFile->findPrevious(T_CLOSURE, $stackPtr, $opener);
             if (false !== $isClosure) {
                 return;

SymfonyCustom/Sniffs/Namespaces/UnusedUseSniff.php

@@ -311,7 +311,7 @@ private function isClassUsed(File $phpcsFile, int $usePtr, int $classPtr): bool
                 || ('class' === $type
                     && ((T_DOC_COMMENT_STRING === $tokens[$classUsed]['code']
                             && preg_match(
-                                '/(\s|\||\(|\<|\,|^)'.preg_quote($searchName, '/').'(\s|\||\\\\|\<|\,|\>|$|\[\])/i',
+                                '/(\s|\||\(|\<|\,|\:|^)'.preg_quote($searchName, '/').'(\s|\||\\\\|\<|\,|\>|$|\[\])/i',
                                 $tokens[$classUsed]['content']
                             ))
                         || (T_DOC_COMMENT_TAG === $tokens[$classUsed]['code']

SymfonyCustom/Tests/Namespaces/UnusedUseUnitTest.inc

@@ -136,10 +136,17 @@ namespace BugCollection;
 
 use Doctrine\Collection;
 use Doctrine\Value;
+use Doctrine\Value2;
 use Doctrine\Key;
+use Doctrine\Key2;
+use Used\Schemetype;
+use Used\Host;
+use NotUsed\Path;
 
 /**
  * @param Collection<Key, Value> $a
+ * @param Collection<Key2,Value2> $a
+ * @param array{scheme:Schemetype,host: Host,path:string} $parsed_url
  *
  * @return null
  */

SymfonyCustom/Tests/Namespaces/UnusedUseUnitTest.inc.fixed

@@ -123,10 +123,16 @@ namespace BugCollection;
 
 use Doctrine\Collection;
 use Doctrine\Value;
+use Doctrine\Value2;
 use Doctrine\Key;
+use Doctrine\Key2;
+use Used\Schemetype;
+use Used\Host;
 
 /**
  * @param Collection<Key, Value> $a
+ * @param Collection<Key2,Value2> $a
+ * @param array{scheme:Schemetype,host: Host,path:string} $parsed_url
  *
  * @return null
  */

SymfonyCustom/Tests/Namespaces/UnusedUseUnitTest.php

@@ -37,6 +37,7 @@ protected function getErrorList(): array
             127 => 1,
             128 => 1,
             129 => 1,
+            144 => 1,
         ];
     }