Skip to content

Commit 47a20bc

Browse files
committed
Remove tests for issue 2603 as suggested during PR review
1 parent 8f9bacc commit 47a20bc

File tree

2 files changed

+6
-22
lines changed

2 files changed

+6
-22
lines changed

WordPress/Tests/WP/AlternativeFunctionsUnitTest.inc

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -156,22 +156,6 @@ MyNamespace\curl_init();
156156
\MyNamespace\curl_init();
157157
namespace\curl_init(); // The sniff should start flagging this once it can resolve relative namespaces.
158158

159-
/*
160-
* Safeguard correct handling of namespaced parameters passed to file_get_contents().
161-
*
162-
* Note: the sniff should flag the examples using a fully qualified namespaced name and partially
163-
* qualified name, but currently does not. This will be addressed via
164-
* https://github.com/WordPress/WordPress-Coding-Standards/issues/2603.
165-
*/
166-
file_get_contents(\wp_upload_dir()['path'] . 'subdir/file.inc');
167-
file_get_contents(MyNamespace\wp_upload_dir()['path'] . 'subdir/file.inc');
168-
file_get_contents(\MyNamespace\wp_upload_dir()['path'] . 'subdir/file.inc');
169-
file_get_contents(namespace\wp_upload_dir()['path'] . 'subdir/file.inc');
170-
file_get_contents(\ABSPATH . 'wp-admin/css/some-file.css');
171-
file_get_contents(MyNamespace\ABSPATH . 'wp-admin/css/some-file.css');
172-
file_get_contents(\MyNamespace\ABSPATH . 'wp-admin/css/some-file.css');
173-
file_get_contents(namespace\ABSPATH . 'wp-admin/css/some-file.css');
174-
175159
/*
176160
* Safeguard that the sniff does not incorrectly ignore class methods/constants with the same
177161
* name as WordPress global functions/constants when used in file_get_contents().

WordPress/Tests/WP/AlternativeFunctionsUnitTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,12 @@ public function getWarningList() {
9090
142 => 1,
9191
146 => 1,
9292
154 => 1,
93-
179 => 1,
94-
180 => 1,
95-
181 => 1,
96-
182 => 1,
97-
183 => 1,
98-
184 => 1,
93+
163 => 1,
94+
164 => 1,
95+
165 => 1,
96+
166 => 1,
97+
167 => 1,
98+
168 => 1,
9999
);
100100
}
101101
}

0 commit comments

Comments
 (0)