Skip to content

Conversation

@rodrigoprimo
Copy link
Collaborator

Description

Update old https://vip.wordpress.com/documentation URLs to new https://docs.wpvip.com URLs in multiple sniff docblocks. The old links are redirecting to a generic page that doesn't provide any useful information about the related sniff.

I was not able to find the corresponding new link for EnqueuedResourcesSniff, so I opted to remove the old link. I'm not familiar with WordPress VIP docs so I might have missed the new location.

It seems it is not the first time that WordPress VIP changed those URLs without configuring proper redirects (see #1499).

Suggested changelog entry

N/A

Update old https://vip.wordpress.com/documentation URLs to new https://docs.wpvip.com URLs in multiple sniff docblocks. The old links are redirecting to a generic page that doesn't provide any useful information about the related sniff.

I was not able to find the corresponding new link for `EnqueuedResourcesSniff`, so I opted to remove the old link.
@GaryJones
Copy link
Member

GaryJones commented Oct 27, 2025

cc @yolih

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified old vs new links

@GaryJones Considering you are probably most familiar with the VIP documentation, would you be able to suggest an alternative link for the EnqueuedResources docblock link ?

Also: it might be a good idea to flag internally within A8C that these type of documentation reorganizations leave a lot of broken links around the web.... ?

@jrfnl
Copy link
Member

jrfnl commented Oct 27, 2025

@GaryJones 😁 We were clearly posting at the same time ;-)

@jrfnl
Copy link
Member

jrfnl commented Oct 27, 2025

@GaryJones Hmm.. just noticed that the /cc-ed name is not actually a person, but a GH organisation. Could you double-check that you copied in the correct person ?

@jrfnl jrfnl added this to the 3.3.0 milestone Oct 27, 2025
@GaryJones
Copy link
Member

Comment fixed, so tagging @yolih now.

@yolih
Copy link

yolih commented Oct 27, 2025

@rodrigoprimo Thank you so much for taking the time to locate suitable URL replacements for these sniffs!
The vip.wordpress.com domain has not hosted VIP's documentation in over 6 years, so these updates are well overdue.

My suggestion for a corresponding link for EnqueuedResourcesSniff:
https://docs.wpvip.com/php_codesniffer/phpcs-report/#h-warnings-at-severity-level-4-and-under

@rodrigoprimo
Copy link
Collaborator Author

Thanks for the suggestion, @yolih! I don't think this is a good replacement as this link is about how VIPCS categorizes PHPCS errors/warnings by severity and not about the EnqueuedResources sniff. I believe we can leave this sniff without a link.

@jrfnl jrfnl merged commit bb822fe into WordPress:develop Nov 10, 2025
29 checks passed
@rodrigoprimo rodrigoprimo deleted the fix-vip-links branch November 26, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants