-
-
Notifications
You must be signed in to change notification settings - Fork 244
Add support for affected_by_commits, fixed_by_commits, and OSV code fix commits #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… in Advisory Signed-off-by: ziad hany <ziadhany2016@gmail.com>
2af10cf to
a8ec9f1
Compare
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
|
@ziadhany add description in the PR please! |
Add all the fields in keys for comparison CodeCommitData Signed-off-by: ziad hany <ziadhany2016@gmail.com>
|
@ziadhany mostly looks good! Please run the importer once and paste the logs here. Thanks! I want to see if we are missing on any data in OSV format. And how does the AdvisoryData and ImpactedPackages looks with the new CommitData. Thanks! |
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
|
@TG1999 This is the log output for the following importers:
the database query result : |
Why are we getting in this logs? The commit data should have been created for this |
|
See all when we have introduced and fixed events to create code commit data. |
…ported Signed-off-by: ziad hany <ziadhany2016@gmail.com>
|
I updated the script to handle unsupported packages (especially for OSS-Fuzz). CodeCommit is no longer ignored even if the package is unsupported, and logs are now more meaningful. This is the updated logs: the database query result : Issues related:
|
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
|
This log does not tell me a lot, what's the data. Why this is unsupported. |
|
One of the list might not be a valid version, but all others are valid, are we ingesting them or skipping whole list if we can't ingest one. |
@TG1999 We are ignoring GHSA files since we target only PYSEC files. |
Then add that to the log as well :) |
We are skipping this since the version range would likely be inconsistent if we processed it. I can changes this if needed. |
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@keshav-space @pombredanne thoughts on this one ? |
|
For PYSEC data we would be using github version range, coz the versions are Semver. And if a version is not parsable that version should be skipped. Not the entire range. Also we should introduce a flag for advisories that were not completely parsed. So in future if our parsing techniques gets better we can delete the incomplete parsed advisory with a new one. |
affected_by_commitsandfixed_by_commitsfields in our advisoryfrom_dictandto_dictmethodscompute_checksummethodCodeCommitDataimporter class