Fix unit tests

Author: devksingh4

tests/unit/functions/github.test.ts

@@ -256,6 +256,14 @@ describe("assignIdpGroupsToTeam", () => {
       },
     ];
 
+    // Mock team ID to slug resolution
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { slug: "test-team" },
+    });
+
+    // Mock team sync availability check
+    mockOctokit.request.mockResolvedValueOnce({});
+
     // Mock IdP group searches (successful on first attempt)
     mockOctokit.request
       .mockResolvedValueOnce({
@@ -271,18 +279,18 @@ describe("assignIdpGroupsToTeam", () => {
     await assignIdpGroupsToTeam(defaultInputs);
 
     expect(mockOctokit.request).toHaveBeenCalledWith(
-      "PATCH /orgs/{org}/teams/{team_id}/team-sync/group-mappings",
+      "PATCH /orgs/{org}/teams/{team_slug}/team-sync/group-mappings",
       {
         org: "test-org",
-        team_id: 123,
+        team_slug: "test-team",
         groups: mockGroups,
         headers: {
           "X-GitHub-Api-Version": "2022-11-28",
         },
       }
     );
     expect(mockLogger.info).toHaveBeenCalledWith(
-      "Successfully mapped IdP groups to team 123"
+      "Successfully mapped IdP groups to team test-team"
     );
   });
 
@@ -293,6 +301,14 @@ describe("assignIdpGroupsToTeam", () => {
       group_description: "First group",
     };
 
+    // Mock team ID to slug resolution
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { slug: "test-team" },
+    });
+
+    // Mock team sync availability check
+    mockOctokit.request.mockResolvedValueOnce({});
+
     // First attempt throws error, second succeeds
     mockOctokit.request
       .mockRejectedValueOnce(new Error("API Error"))
@@ -311,8 +327,15 @@ describe("assignIdpGroupsToTeam", () => {
     );
   });
 
-
   it("should throw GithubError if IdP group not found after max retries", async () => {
+    // Mock team ID to slug resolution
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { slug: "test-team" },
+    });
+
+    // Mock team sync availability check
+    mockOctokit.request.mockResolvedValueOnce({});
+
     // All 5 attempts return empty groups
     mockOctokit.request.mockResolvedValue({ data: { groups: [] } });
 
@@ -322,7 +345,7 @@ describe("assignIdpGroupsToTeam", () => {
     expect(mockLogger.error).toHaveBeenCalledWith(
       "Failed to find IdP group with ID group-1 after 5 retries"
     );
-    expect(mockOctokit.request).toHaveBeenCalledTimes(5); // 5 retries for first group
+    expect(mockOctokit.request).toHaveBeenCalledTimes(7); // 1 for slug resolution + 1 for sync check + 5 retries for first group
   });
 
   it("should handle IdP groups without description", async () => {
@@ -332,6 +355,14 @@ describe("assignIdpGroupsToTeam", () => {
       group_description: undefined,
     };
 
+    // Mock team ID to slug resolution
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { slug: "test-team" },
+    });
+
+    // Mock team sync availability check
+    mockOctokit.request.mockResolvedValueOnce({});
+
     mockOctokit.request
       .mockResolvedValueOnce({ data: { groups: [mockGroup] } })
       .mockResolvedValueOnce({});
@@ -342,7 +373,7 @@ describe("assignIdpGroupsToTeam", () => {
     });
 
     expect(mockOctokit.request).toHaveBeenCalledWith(
-      "PATCH /orgs/{org}/teams/{team_id}/team-sync/group-mappings",
+      "PATCH /orgs/{org}/teams/{team_slug}/team-sync/group-mappings",
       expect.objectContaining({
         groups: [
           {
@@ -365,6 +396,14 @@ describe("assignIdpGroupsToTeam", () => {
   });
 
   it("should wrap non-BaseError exceptions in GithubError", async () => {
+    // Mock team ID to slug resolution
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { slug: "test-team" },
+    });
+
+    // Mock team sync availability check
+    mockOctokit.request.mockResolvedValueOnce({});
+
     mockOctokit.request
       .mockResolvedValueOnce({
         data: { groups: [{ group_id: "group-1", group_name: "Group One" }] },
@@ -381,4 +420,118 @@ describe("assignIdpGroupsToTeam", () => {
       "Failed to assign IdP groups to team 123"
     );
   });
+
+  it("should resolve team ID to slug", async () => {
+    const mockGroup = {
+      group_id: "group-1",
+      group_name: "Group One",
+      group_description: "First group",
+    };
+
+    // Mock team ID to slug resolution
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { slug: "my-team-slug" },
+    });
+
+    // Mock team sync availability check
+    mockOctokit.request.mockResolvedValueOnce({});
+
+    // Mock IdP group search
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { groups: [mockGroup] },
+    });
+
+    // Mock PATCH request
+    mockOctokit.request.mockResolvedValueOnce({});
+
+    await assignIdpGroupsToTeam({
+      ...defaultInputs,
+      groupsToSync: ["group-1"],
+    });
+
+    expect(mockOctokit.request).toHaveBeenCalledWith(
+      "GET /orgs/{org}/teams/{team_id}",
+      {
+        org: "test-org",
+        team_id: 123,
+        headers: {
+          "X-GitHub-Api-Version": "2022-11-28",
+        },
+      }
+    );
+    expect(mockLogger.info).toHaveBeenCalledWith(
+      "Resolved team ID 123 to slug: my-team-slug"
+    );
+  });
+
+  it("should throw GithubError if team slug resolution fails", async () => {
+    // Mock team ID to slug resolution failure
+    mockOctokit.request.mockRejectedValueOnce(new Error("Team not found"));
+
+    await expect(assignIdpGroupsToTeam(defaultInputs)).rejects.toThrow(
+      GithubError
+    );
+    expect(mockLogger.error).toHaveBeenCalledWith(
+      "Failed to resolve team ID 123 to slug:",
+      expect.any(Error)
+    );
+  });
+
+  it("should exit gracefully if team sync is not available (404)", async () => {
+    // Mock team ID to slug resolution
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { slug: "test-team" },
+    });
+
+    // Mock team sync availability check returning 404
+    mockOctokit.request.mockRejectedValueOnce({
+      status: 404,
+      message: "Not Found",
+    });
+
+    await assignIdpGroupsToTeam(defaultInputs);
+
+    expect(mockLogger.warn).toHaveBeenCalledWith(
+      expect.stringContaining("Team sync is not available for team test-team")
+    );
+    expect(mockLogger.warn).toHaveBeenCalledWith("Skipping IdP group assignment");
+    // Should not attempt to search for groups or patch
+    expect(mockOctokit.request).toHaveBeenCalledTimes(2); // Only slug resolution and sync check
+  });
+
+  it("should exit gracefully if PATCH returns 404", async () => {
+    const mockGroup = {
+      group_id: "group-1",
+      group_name: "Group One",
+      group_description: "First group",
+    };
+
+    // Mock team ID to slug resolution
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { slug: "test-team" },
+    });
+
+    // Mock team sync availability check
+    mockOctokit.request.mockResolvedValueOnce({});
+
+    // Mock IdP group search
+    mockOctokit.request.mockResolvedValueOnce({
+      data: { groups: [mockGroup] },
+    });
+
+    // Mock PATCH request returning 404
+    mockOctokit.request.mockRejectedValueOnce({
+      status: 404,
+      message: "Not Found",
+    });
+
+    await assignIdpGroupsToTeam({
+      ...defaultInputs,
+      groupsToSync: ["group-1"],
+    });
+
+    expect(mockLogger.warn).toHaveBeenCalledWith(
+      "Team sync endpoint not available for team 123. IdP groups were not assigned."
+    );
+  });
 });