Allow logging to be toggled

Author: pmundt

README.md

@@ -23,15 +23,20 @@ General usage is as follows:
 ```
 $ k8s-node-label-monitor --help
 Node Label Monitor for Kubernetes
- Usage: k8s-node-label-monitor [flags]
- 
-   -c string
-     	Manually trigger named CronJob on label changes
-   -kubeconfig string
-     	Paths to a kubeconfig. Only required if out-of-cluster.
-   -l	Only track changes to the local node
-   -n string
-     	Notification endpoint to POST updates to
+Usage: k8s-node-label-monitor [flags]
+
+  -cronjob string
+    	Manually trigger named CronJob on label changes
+  -endpoint string
+    	Notification endpoint to POST updates to
+  -kubeconfig string
+    	Paths to a kubeconfig. Only required if out-of-cluster.
+  -local
+    	Only track changes to the local node
+  -logging
+    	Enable/disable logging (default true)
+  -master --kubeconfig
+    	(Deprecated: switch to --kubeconfig) The address of the Kubernetes API server. Overrides any value in kubeconfig. Only required if out-of-cluster.
 ```
 
 ### Running Node-Local via Docker

k8s-node-label-monitor-node-local-daemonset.yaml

@@ -53,4 +53,4 @@ spec:
           name: node-label-monitor
           args:
             # Run in node-local mode
-            - "-l"
+            - "-local"

main.go

@@ -22,6 +22,7 @@ import (
 var (
 	monitorName = "k8s-node-label-monitor"
 	nodeLocal   = false
+	logging     = true
 	cronjob     = ""
 	log         = logf.Log.WithName(monitorName)
 	nodeLabels  = map[string]map[string]string{}
@@ -210,9 +211,10 @@ func enqueueNodeUpdate(nodeName string, queue workqueue.RateLimitingInterface) {
 func main() {
 	var endpoint string
 
-	flag.BoolVar(&nodeLocal, "l", false, "Only track changes to the local node")
-	flag.StringVar(&cronjob, "c", "", "Manually trigger named CronJob on label changes")
-	flag.StringVar(&endpoint, "n", "", "Notification endpoint to POST updates to")
+	flag.BoolVar(&nodeLocal, "local", false, "Only track changes to the local node")
+	flag.BoolVar(&logging, "logging", true, "Enable/disable logging")
+	flag.StringVar(&cronjob, "cronjob", "", "Manually trigger named CronJob on label changes")
+	flag.StringVar(&endpoint, "endpoint", "", "Notification endpoint to POST updates to")
 
 	flag.Usage = func() {
 		fmt.Fprintf(os.Stderr, "Node Label Monitor for Kubernetes\n")
@@ -274,8 +276,10 @@ func main() {
 	controller := NewController(queue, indexer, informer)
 
 	// Set up the notifiers for this controller
-	log.Info("Enabling Logging notifier")
-	controller.notifiers = append(controller.notifiers, notifiers.LogNotifier{})
+	if logging {
+		log.Info("Enabling Logging notifier")
+		controller.notifiers = append(controller.notifiers, notifiers.LogNotifier{})
+	}
 
 	if len(endpoint) > 0 {
 		notifier, err := notifiers.NewEndpointNotifier(log, endpoint)