Skip to content

Commit f8fd142

Browse files
committed
[c++] Formatting and use of const.
1 parent 67df80c commit f8fd142

File tree

2 files changed

+17
-20
lines changed

2 files changed

+17
-20
lines changed

sbe-tool/src/main/cpp/otf/OtfHeaderDecoder.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,22 +107,22 @@ class OtfHeaderDecoder
107107
* All elements must be unsigned integers according to Specification
108108
*/
109109

110-
std::uint64_t getTemplateId(const char *headerBuffer)
110+
std::uint64_t getTemplateId(const char *headerBuffer) const
111111
{
112112
return Encoding::getUInt(m_templateIdType, m_templateIdByteOrder, headerBuffer + m_templateIdOffset);
113113
}
114114

115-
std::uint64_t getSchemaId(const char *headerBuffer)
115+
std::uint64_t getSchemaId(const char *headerBuffer) const
116116
{
117117
return Encoding::getUInt(m_schemaIdType, m_schemaIdByteOrder, headerBuffer + m_schemaIdOffset);
118118
}
119119

120-
std::uint64_t getSchemaVersion(const char *headerBuffer)
120+
std::uint64_t getSchemaVersion(const char *headerBuffer) const
121121
{
122122
return Encoding::getUInt(m_schemaVersionType, m_schemaVersionByteOrder, headerBuffer + m_schemaVersionOffset);
123123
}
124124

125-
std::uint64_t getBlockLength(const char *headerBuffer)
125+
std::uint64_t getBlockLength(const char *headerBuffer) const
126126
{
127127
return Encoding::getUInt(m_blockLengthType, m_blockLengthByteOrder, headerBuffer + m_blockLengthOffset);
128128
}

sbe-tool/src/main/cpp/otf/OtfMessageDecoder.h

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,7 @@ std::size_t decodeData(
281281

282282
// TODO: is length always unsigned according to spec?
283283
std::uint64_t dataLength = isPresent ?
284-
lengthToken.encoding().getAsUInt(buffer + bufferIndex + lengthToken.offset())
285-
: 0;
284+
lengthToken.encoding().getAsUInt(buffer + bufferIndex + lengthToken.offset()) : 0;
286285

287286
if (isPresent)
288287
{
@@ -336,11 +335,9 @@ std::pair<size_t, size_t> decodeGroups(
336335
Token& numInGroupToken = tokens->at(tokenIndex + 3);
337336

338337
std::uint64_t blockLength = isPresent ?
339-
blockLengthToken.encoding().getAsUInt(buffer + bufferIndex + blockLengthToken.offset())
340-
: 0;
338+
blockLengthToken.encoding().getAsUInt(buffer + bufferIndex + blockLengthToken.offset()) : 0;
341339
std::uint64_t numInGroup = isPresent ?
342-
numInGroupToken.encoding().getAsUInt(buffer + bufferIndex + numInGroupToken.offset())
343-
: 0;
340+
numInGroupToken.encoding().getAsUInt(buffer + bufferIndex + numInGroupToken.offset()) : 0;
344341

345342
if (isPresent)
346343
{
@@ -360,15 +357,15 @@ std::pair<size_t, size_t> decodeGroups(
360357
throw std::runtime_error("length too short for group blockLength");
361358
}
362359

363-
size_t afterFieldsIndex =
364-
decodeFields(buffer, bufferIndex, length, actingVersion, tokens, beginFieldsIndex, numTokens, listener);
360+
size_t afterFieldsIndex = decodeFields(
361+
buffer, bufferIndex, length, actingVersion, tokens, beginFieldsIndex, numTokens, listener);
365362
bufferIndex += blockLength;
366363

367-
std::pair<size_t, size_t> groupsResult =
368-
decodeGroups(buffer, bufferIndex, length, actingVersion, tokens, afterFieldsIndex, numTokens, listener);
364+
std::pair<size_t, size_t> groupsResult = decodeGroups(
365+
buffer, bufferIndex, length, actingVersion, tokens, afterFieldsIndex, numTokens, listener);
369366

370-
bufferIndex =
371-
decodeData(buffer, groupsResult.first, length, tokens, groupsResult.second, numTokens, actingVersion, listener);
367+
bufferIndex = decodeData(
368+
buffer, groupsResult.first, length, tokens, groupsResult.second, numTokens, actingVersion, listener);
372369

373370
listener.onEndGroup(token, i, numInGroup);
374371
}
@@ -403,11 +400,11 @@ std::size_t decode(
403400

404401
size_t bufferIndex = blockLength;
405402

406-
std::pair<size_t, size_t> groupResult =
407-
decodeGroups(buffer, bufferIndex, length, actingVersion, msgTokens, tokenIndex, numTokens, listener);
403+
std::pair<size_t, size_t> groupResult = decodeGroups(
404+
buffer, bufferIndex, length, actingVersion, msgTokens, tokenIndex, numTokens, listener);
408405

409-
bufferIndex =
410-
decodeData(buffer, groupResult.first, length, msgTokens, groupResult.second, numTokens, actingVersion, listener);
406+
bufferIndex = decodeData(
407+
buffer, groupResult.first, length, msgTokens, groupResult.second, numTokens, actingVersion, listener);
411408

412409
listener.onEndMessage(msgTokens->at(numTokens - 1));
413410

0 commit comments

Comments
 (0)