1. Updated InhibitoryActivation class methods:

LukasMolzberger · LukasMolzberger · commit 3e1002d72ebe · 2025-05-14T14:55:28.000+02:00
- Made getOutputLink(int bsId) const-qualified
    - Made getInputLinks() and getOutputLinks() const-qualified
    - Added proper const qualifiers to getCorrespondingInputLink and getCorrespondingOutputLink
  2. Fixed Link class methods:
    - Made getSynapse(), getInput(), getOutput(), isCausal(), and getDocument() const-qualified
    - Updated followSingleRelation to be const-qualified
  3. Fixed Type and Obj classes:
    - Made isInstanceOf, toKeyString, getFieldValue, and getFieldUpdatedValue const-qualified
    - Fixed getFlattenedTypeInputSide and getFlattenedTypeOutputSide to be const
diff --git a/include/fields/obj.h b/include/fields/obj.h
@@ -19,17 +19,17 @@ class Obj : public QueueProvider {
     void initFields();
     Type* getType() const;
     virtual RelatedObjectIterable* followManyRelation(Relation* rel) const = 0;
-    virtual Obj* followSingleRelation(const Relation* rel) = 0;
-    bool isInstanceOf(Type* t);
+    virtual Obj* followSingleRelation(const Relation* rel) const = 0;
+    bool isInstanceOf(Type* t) const;
     Field* getFieldInput(FieldDefinition* fd) const;
     Field* getFieldOutput(FieldDefinition* fd) const;
     Field* getOrCreateFieldInput(FieldDefinition* fd);
     Obj& setFieldValue(FieldDefinition* fd, double v);
-    double getFieldValue(FieldDefinition* fd);
-    double getFieldUpdatedValue(FieldDefinition* fd);
-    Field** getFields();
+    double getFieldValue(FieldDefinition* fd) const;
+    double getFieldUpdatedValue(FieldDefinition* fd) const;
+    Field** getFields() const;
 
-    std::string toKeyString();
+    std::string toKeyString() const;
     std::string toString() const;
     std::string getFieldAsString(FieldDefinition* fd) const;
 };
diff --git a/include/fields/test_object.h b/include/fields/test_object.h
@@ -16,7 +16,7 @@ class TestObject : public Obj {
     explicit TestObject(TestType* type);
 
     // Follow a single relation
-    Obj* followSingleRelation(const Relation* rel) override;
+    Obj* followSingleRelation(const Relation* rel) const override;
 
     // Get related test object
     TestObject* getRelatedTestObject() const;
diff --git a/include/fields/type.h b/include/fields/type.h
@@ -49,12 +49,12 @@ class Type {
     std::set<Type*> collectTypes();
     void collectTypesRecursiveStep(std::set<Type*>& sortedTypes);
     int getDepth() const;
-    bool isInstanceOf(Obj* obj);
-    bool isInstanceOf(Type* type);
+    bool isInstanceOf(Obj* obj) const;
+    bool isInstanceOf(Type* type) const;
     std::string getName() const;
-    TypeRegistry* getTypeRegistry();
-    FlattenedType* getFlattenedTypeInputSide();
-    FlattenedType* getFlattenedTypeOutputSide();
+    TypeRegistry* getTypeRegistry() const;
+    FlattenedType* getFlattenedTypeInputSide() const;
+    FlattenedType* getFlattenedTypeOutputSide() const;
     void setFieldDefinition(FieldDefinition* fieldDef);
     std::set<FieldDefinition*> getFieldDefinitions() const;
     Type& addParent(Type* p);
diff --git a/include/network/activation.h b/include/network/activation.h
@@ -28,48 +28,48 @@ class Activation : public Obj, public Element, public ModelProvider {
 
     // Implementation of Obj virtual methods
     RelatedObjectIterable* followManyRelation(Relation* rel) const override;
-    Obj* followSingleRelation(const Relation* rel) override;
+    Obj* followSingleRelation(const Relation* rel) const override;
     
-    ActivationKey getKey();
-    Activation* getParent();
+    ActivationKey getKey() const;
+    Activation* getParent() const;
     void addOutputLink(Link* l);
     virtual void addInputLink(Link* l) = 0;
-    BindingSignal* getBindingSignal(BSType s);
-    std::map<BSType, BindingSignal*> getBindingSignals();
-    bool hasConflictingBindingSignals(std::map<BSType, BindingSignal*> targetBindingSignals);
-    bool isConflictingBindingSignal(BSType s, BindingSignal* targetBS);
-    bool hasNewBindingSignals(std::map<BSType, BindingSignal*> targetBindingSignals);
+    BindingSignal* getBindingSignal(BSType s) const;
+    std::map<BSType, BindingSignal*> getBindingSignals() const;
+    bool hasConflictingBindingSignals(std::map<BSType, BindingSignal*> targetBindingSignals) const;
+    bool isConflictingBindingSignal(BSType s, BindingSignal* targetBS) const;
+    bool hasNewBindingSignals(std::map<BSType, BindingSignal*> targetBindingSignals) const;
     Activation* branch(std::map<BSType, BindingSignal*> bindingSignals);
     void linkOutgoing();
     void linkOutgoing(Synapse* targetSyn);
     void propagate(Synapse* targetSyn);
     virtual void linkIncoming(Activation* excludedInputAct) = 0;
     std::set<Activation*> collectLinkingTargets(Neuron* n);
-    int getId();
+    int getId() const;
     long getCreated() const override;
     void setCreated(long ts);
     long getFired() const override;
     void setFired();
     void setFired(long f);
     void updateFiredStep(Field* net);
     Queue* getQueue() const override;
-    Neuron* getNeuron();
-    Document* getDocument();
-    Model* getModel() override;
-    Config* getConfig() override;
-    Link* getCorrespondingInputLink(Link* l);
-    Link* getCorrespondingOutputLink(Link* l);
-    std::vector<Link*> getInputLinks(LinkDefinition* linkDefinition);
-    virtual std::vector<Link*> getInputLinks() = 0;
-    std::vector<Link*> getOutputLinks(LinkDefinition* linkDefinition);
-    std::vector<Link*> getOutputLinks();
-    Link* getOutputLink(Neuron* n);
-    std::vector<Link*> getOutputLinks(Synapse* s);
-    int compareTo(Activation* act);
-    bool equals(Activation* o);
-    int hashCode();
-    std::string toString();
-    std::string toKeyString();
+    Neuron* getNeuron() const;
+    Document* getDocument() const;
+    Model* getModel() const override;
+    Config* getConfig() const override;
+    Link* getCorrespondingInputLink(const Link* l) const;
+    Link* getCorrespondingOutputLink(const Link* l) const;
+    std::vector<Link*> getInputLinks(LinkDefinition* linkDefinition) const;
+    virtual std::vector<Link*> getInputLinks() const = 0;
+    std::vector<Link*> getOutputLinks(LinkDefinition* linkDefinition) const;
+    std::vector<Link*> getOutputLinks() const;
+    Link* getOutputLink(Neuron* n) const;
+    std::vector<Link*> getOutputLinks(Synapse* s) const;
+    int compareTo(Activation* act) const;
+    bool equals(Activation* o) const;
+    int hashCode() const;
+    std::string toString() const override;
+    std::string toKeyString() const override;
 
 protected:
     int id;
diff --git a/include/network/conjunctive_activation.h b/include/network/conjunctive_activation.h
@@ -13,7 +13,7 @@ class ConjunctiveActivation : public Activation {
     
     void linkIncoming(Activation* excludedInputAct) override;
     void addInputLink(Link* l) override;
-    std::vector<Link*> getInputLinks() override;
+    std::vector<Link*> getInputLinks() const override;
 
 private:
     std::map<int, Link*> inputLinks;
diff --git a/include/network/disjunctive_activation.h b/include/network/disjunctive_activation.h
@@ -13,7 +13,7 @@ class DisjunctiveActivation : public Activation {
     
     void linkIncoming(Activation* excludedInputAct) override;
     void addInputLink(Link* l) override;
-    std::vector<Link*> getInputLinks() override;
+    std::vector<Link*> getInputLinks() const override;
 
 private:
     std::map<int, Link*> inputLinks;
diff --git a/include/network/document.h b/include/network/document.h
@@ -20,8 +20,8 @@ class Document : public Queue, public ModelProvider, public QueueProvider {
     long getId() const;
     long getTimeout() const override;
     void process(std::function<bool(Step*)> filter);
-    Model* getModel() override;
-    Config* getConfig() override;
+    Model* getModel() const override;
+    Config* getConfig() const override;
     Step* getCurrentStep();
     void addActivation(Activation* act);
     std::set<Activation*> getActivations();
diff --git a/include/network/element.h b/include/network/element.h
@@ -6,8 +6,8 @@
 class Element : public QueueProvider {
 public:
     virtual ~Element() = default;
-    virtual long getCreated() = 0;
-    virtual long getFired() = 0;
+    virtual long getCreated() const = 0;
+    virtual long getFired() const = 0;
     // inherited from QueueProvider
     virtual Queue* getQueue() const = 0;
 };
diff --git a/include/network/inhibitory_activation.h b/include/network/inhibitory_activation.h
@@ -13,16 +13,16 @@ class InhibitoryActivation : public Activation {
     RelatedObjectIterable* followManyRelation(Relation* rel) const override;
     
     void addInputLink(Link* l) override;
-    Link* getInputLink(int bsId);
-    int getInputKey(Link* l);
+    Link* getInputLink(int bsId) const;
+    int getInputKey(Link* l) const;
     void addOutputLink(Link* l) override;
-    Link* getOutputLink(int bsId);
-    int getOutputKey(Link* l);
+    Link* getOutputLink(int bsId) const;
+    int getOutputKey(Link* l) const;
     void linkIncoming(Activation* excludedInputAct) override;
-    std::vector<Link*> getInputLinks() override;
-    std::vector<Link*> getOutputLinks() override;
-    Link* getCorrespondingInputLink(Link* l) override;
-    Link* getCorrespondingOutputLink(Link* l) override;
+    std::vector<Link*> getInputLinks() const override;
+    std::vector<Link*> getOutputLinks() const override;
+    Link* getCorrespondingInputLink(const Link* l) const override;
+    Link* getCorrespondingOutputLink(const Link* l) const override;
 
 private:
     std::map<int, Link*> inputLinks;
diff --git a/include/network/link.h b/include/network/link.h
@@ -21,23 +21,23 @@ class Link : public Obj, public Element, public ModelProvider {
     Link(LinkDefinition* type, Synapse* s, Activation* input, Activation* output);
 
     RelatedObjectIterable* followManyRelation(Relation* rel) const override;
-    Obj* followSingleRelation(const Relation* rel) override;
+    Obj* followSingleRelation(const Relation* rel) const override;
     long getFired() const override;
     long getCreated() const override;
-    Synapse* getSynapse();
+    Synapse* getSynapse() const;
     void setSynapse(Synapse* synapse);
-    Activation* getInput();
-    Activation* getOutput();
-    bool isCausal();
+    Activation* getInput() const;
+    Activation* getOutput() const;
+    bool isCausal() const;
     static bool isCausal(Activation* iAct, Activation* oAct);
-    Document* getDocument();
+    Document* getDocument() const;
     Queue* getQueue() const override;
-    Model* getModel() override;
-    Config* getConfig() override;
-    std::string getInputKeyString();
-    std::string getOutputKeyString();
-    std::string toString();
-    std::string toKeyString();
+    Model* getModel() const override;
+    Config* getConfig() const override;
+    std::string getInputKeyString() const;
+    std::string getOutputKeyString() const;
+    std::string toString() const;
+    std::string toKeyString() const;
 
 private:
     Synapse* synapse;
diff --git a/include/network/model.h b/include/network/model.h
@@ -29,7 +29,7 @@ class Model : public Queue {
     void open(bool create);
     void close(bool store);
     long createThoughtId();
-    Config* getConfig();
+    Config* getConfig() const;
     void setConfig(Config* config);
     void write(std::ostream& out) const;
     void readFields(std::istream& in, Model* m);
diff --git a/include/network/model_provider.h b/include/network/model_provider.h
@@ -7,8 +7,8 @@
 class ModelProvider {
 public:
     virtual ~ModelProvider() = default;
-    virtual Model* getModel() = 0;
-    virtual Config* getConfig() = 0;
+    virtual Model* getModel() const = 0;
+    virtual Config* getConfig() const = 0;
 
 protected:
     Model* model;
diff --git a/include/network/neuron.h b/include/network/neuron.h
@@ -28,8 +28,8 @@ class Neuron : public Obj, public Element, public ModelProvider {
     int getNewSynapseId();
     Activation* createActivation(Activation* parent, Document* doc, std::map<BSType*, BindingSignal*> bindingSignals);
     void deleteNeuron();
-    Model* getModel() override;
-    Config* getConfig() override;
+    Model* getModel() const override;
+    Config* getConfig() const override;
     void setModified();
     void resetModified();
     bool isModified() const;
diff --git a/src/fields/obj.cpp b/src/fields/obj.cpp
@@ -25,7 +25,7 @@ Type* Obj::getType() const {
     return type;
 }
 
-bool Obj::isInstanceOf(Type* t) {
+bool Obj::isInstanceOf(Type* t) const {
     return type->isInstanceOf(t);
 }
 
@@ -55,21 +55,21 @@ Obj& Obj::setFieldValue(FieldDefinition* fd, double v) {
     return *this;
 }
 
-double Obj::getFieldValue(FieldDefinition* fd) {
+double Obj::getFieldValue(FieldDefinition* fd) const {
     auto f = getFieldOutput(fd);
     return f ? f->getValue() : 0.0;
 }
 
-double Obj::getFieldUpdatedValue(FieldDefinition* fd) {
+double Obj::getFieldUpdatedValue(FieldDefinition* fd) const {
     auto f = getFieldOutput(fd);
     return f ? f->getUpdatedValue() : 0.0;
 }
 
-Field** Obj::getFields() {
+Field** Obj::getFields() const {
     return fields;
 }
 
-std::string Obj::toKeyString() {
+std::string Obj::toKeyString() const {
     return ""; // Implementation as needed
 }
 
diff --git a/src/fields/queue.cpp b/src/fields/queue.cpp
@@ -4,7 +4,7 @@
 #include <iostream>
 #include <cassert>
 
-long Queue::getTimeout() {
+long Queue::getTimeout() const {
     return std::numeric_limits<long>::max();
 }
 
diff --git a/src/fields/test_object.cpp b/src/fields/test_object.cpp
@@ -4,7 +4,7 @@
 TestObject::TestObject(TestType* type) : Obj(type) {}
 
 // Follow a single relation
-Obj* TestObject::followSingleRelation(const Relation* rel) {
+Obj* TestObject::followSingleRelation(const Relation* rel) const {
     if (rel->getRelationId() == TestType::TEST_RELATION_FROM.getRelationId() || rel->getRelationId() == TestType::TEST_RELATION_TO.getRelationId()) {
         return getRelatedTestObject();
     } else {
diff --git a/src/fields/type.cpp b/src/fields/type.cpp
@@ -72,11 +72,11 @@ int Type::getDepth() const {
     return depth.value();
 }
 
-bool Type::isInstanceOf(Obj* obj) {
+bool Type::isInstanceOf(Obj* obj) const {
     return isInstanceOf(obj->getType());
 }
 
-bool Type::isInstanceOf(Type* type) {
+bool Type::isInstanceOf(Type* type) const {
     return id == type->id || std::any_of(parents.begin(), parents.end(), [&](const auto& p) {
         return p->isInstanceOf(type);
     });
@@ -86,18 +86,18 @@ std::string Type::getName() const {
     return name;
 }
 
-TypeRegistry* Type::getTypeRegistry() {
+TypeRegistry* Type::getTypeRegistry() const {
     return registry;
 }
 
-FlattenedType* Type::getFlattenedTypeInputSide() {
+FlattenedType* Type::getFlattenedTypeInputSide() const {
     if (!flattenedTypeInputSide) {
         throw std::runtime_error("Type has not been flattened yet. TypeRegistry.flattenTypeHierarchy() needs to be called beforehand.");
     }
     return flattenedTypeInputSide;
 }
 
-FlattenedType* Type::getFlattenedTypeOutputSide() {
+FlattenedType* Type::getFlattenedTypeOutputSide() const {
     if (!flattenedTypeOutputSide) {
         throw std::runtime_error("Type has not been flattened yet. TypeRegistry.flattenTypeHierarchy() needs to be called beforehand.");
     }
diff --git a/src/network/activation.cpp b/src/network/activation.cpp
diff --git a/src/network/conjunctive_activation.cpp b/src/network/conjunctive_activation.cpp
diff --git a/src/network/disjunctive_activation.cpp b/src/network/disjunctive_activation.cpp
diff --git a/src/network/inhibitory_activation.cpp b/src/network/inhibitory_activation.cpp
diff --git a/src/network/link.cpp b/src/network/link.cpp
diff --git a/src/network/model_provider.cpp b/src/network/model_provider.cpp
diff --git a/src/network/neuron.cpp b/src/network/neuron.cpp
diff --git a/src/network/synapse.cpp b/src/network/synapse.cpp
