Skip to content

Commit 1c1b863

Browse files
authored
small improvements (#24)
* added laravel 10 support * Nova action's validateFields not called due overridden ActionRequest * improved readme
1 parent 9d84feb commit 1c1b863

File tree

3 files changed

+31
-3
lines changed

3 files changed

+31
-3
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"license": "MIT",
2121
"require": {
2222
"php": "^8.0",
23-
"laravel/framework": "^8.0|^9.0",
23+
"laravel/framework": "^8.0|^9.0|^10.0",
2424
"laravel/nova": "^4.0"
2525
},
2626
"autoload": {

readme.md

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# nova 4 dependency container
22

3-
A Laravel Nova 4 form container for grouping fields that depend on other field values.
3+
A Laravel Nova 4 form container for grouping fields that depend on other field values.
44
Dependencies can be set on any field type or value.
55

66
Features:
@@ -223,6 +223,29 @@ DependencyContainer::make([
223223
->dependsOn('commentable', 'Post')
224224
```
225225

226+
## Workaround for index or details page
227+
228+
Use the field within resource methods `fieldsForCreate` or `fieldsForUpdate`:
229+
230+
```php
231+
DependencyContainer::make([
232+
Select::make('Parent name', 'parent_id')
233+
->options(...)
234+
])->dependsOn('code', 'column'),
235+
```
236+
237+
To display some values on index or details page,
238+
use any field you like to display the value within resource methods `fieldsForIndex` or `fieldsForDetail`:
239+
240+
```php
241+
Select::make('Parent name', 'parent_id')
242+
->options(...),
243+
244+
// OR
245+
246+
Text::make('Parent name', 'parent_id'),
247+
```
248+
226249
## License
227250

228251
The MIT License (MIT). Please

src/Http/Controllers/ActionController.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Alexwenzel\DependencyContainer\Http\Controllers;
44

5+
use Alexwenzel\DependencyContainer\ActionHasDependencies;
56
use Alexwenzel\DependencyContainer\Http\Requests\ActionRequest;
67
use Laravel\Nova\Http\Requests\ActionRequest as NovaActionRequest;
78
use Laravel\Nova\Http\Controllers\ActionController as NovaActionController;
@@ -16,7 +17,11 @@ class ActionController extends NovaActionController
1617
*/
1718
public function store(NovaActionRequest $request)
1819
{
19-
$request = ActionRequest::createFrom($request);
20+
$action = $request->action();
21+
22+
if (in_array(ActionHasDependencies::class, class_uses_recursive($action))) {
23+
$request = ActionRequest::createFrom($request);
24+
}
2025

2126
return parent::store($request);
2227
}

0 commit comments

Comments
 (0)