Merge pull request #3 from allegro/bugfix/saving-strict-to-other-files

saving-strict | Fixes bug when ts strict could spill to other files

Author: KostkaBrukowa

CHANGELOG.md

@@ -0,0 +1,19 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project
+adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [1.0.1] - 2021-06-01
+
+### Fixed
+
+- Issue when using // @ts-strict in one file would affect other files without this comment resulting
+  in strict mode errors
+
+## [1.0.0] - 2021-05-11
+
+### Added
+
+- First stable version of the plugin

e2e/project-fixture/src/otherFileNotOnPath.ts

@@ -0,0 +1,74 @@
+const assert = require('assert');
+const path = require('path');
+const it = require('../it');
+
+const fileContent = `
+//@ts-strict
+interface TestType { bar: string; }
+const foo: TestType | undefined = undefined;
+const boo = foo.bar;
+`;
+
+const otherFileContent = `
+interface TestType {
+  bar: string;
+}
+
+const foo1: TestType | undefined = undefined;
+
+const boo1 = foo1.bar;
+`;
+
+function findResponse(responses, eventName) {
+  return responses.filter((response) => response.event === eventName);
+}
+
+async function run(server) {
+  const rootPath = path.resolve(__dirname, '../project-fixture/');
+  const file = path.resolve(__dirname, '../project-fixture/' + 'src/notOnPath.ts');
+  const otherFile = path.resolve(__dirname, '../project-fixture/' + 'src/otherFileNotOnPath.ts');
+
+  // open two files
+  server.send({
+    command: 'updateOpen',
+    arguments: {
+      changedFiles: [],
+      closedFiles: [],
+      openFiles: [
+        {
+          file,
+          fileContent,
+          projectRootPath: rootPath,
+          scriptKindName: 'TS',
+        },
+        {
+          file: otherFile,
+          fileContent: otherFileContent,
+          projectRootPath: rootPath,
+          scriptKindName: 'TS',
+        },
+      ],
+    },
+  });
+
+  await server.waitEvent('projectLoadingFinish');
+
+  server.send({ command: 'geterr', arguments: { files: [file, otherFile], delay: 0 } });
+
+  // and wait for both files diagnostics errors
+  await server.waitEvent('semanticDiag');
+  await server.waitEvent('semanticDiag');
+
+  return server.close().then(() => {
+    const semanticDiagEvent = findResponse(server.responses, 'semanticDiag');
+    const fileEvent = semanticDiagEvent.filter((it) => it.body.file === file)[0];
+    const otherFileEvent = semanticDiagEvent.filter((it) => it.body.file === otherFile)[0];
+
+    assert(!!fileEvent);
+    assert(!!otherFileEvent);
+    assert.strictEqual(fileEvent.body.diagnostics.length, 1);
+    assert.strictEqual(otherFileEvent.body.diagnostics.length, 0);
+  });
+}
+
+module.exports = run;

e2e/tests/twoFilesCheckedAtTheSameTime.js

@@ -1,6 +1,6 @@
 {
   "name": "typescript-strict-plugin",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Typescript plugin that allows turning on strict mode in specific files or directories.",
   "author": "Allegro",
   "contributors": [

package-lock.json

@@ -0,0 +1,7 @@
+interface TestType {
+  bar: string;
+}
+
+const foo1: TestType | undefined = undefined;
+
+const boo2 = foo1.bar;

package.json

@@ -1,5 +1,5 @@
-import { PluginInfo, setupProxy, turnOffStrictMode, turnOnStrictMode, log } from './utils';
 import { StrictFileChecker } from './strictFiles';
+import { log, PluginInfo, setupProxy, turnOffStrictMode, turnOnStrictMode } from './utils';
 
 const init: ts.server.PluginModuleFactory = () => {
   function create(info: PluginInfo) {
@@ -10,7 +10,9 @@ const init: ts.server.PluginModuleFactory = () => {
       const strictFile = new StrictFileChecker(info).isFileStrict(fileName);
 
       if (strictFile) {
-        return getDiagnosticsWithStrictMode(info, fileName);
+        turnOnStrictMode(info, info.project.getCompilerOptions());
+      } else {
+        turnOffStrictMode(info, info.project.getCompilerOptions());
       }
 
       return info.languageService.getSemanticDiagnostics(fileName);
@@ -19,16 +21,6 @@ const init: ts.server.PluginModuleFactory = () => {
     return proxy;
   }
 
-  function getDiagnosticsWithStrictMode(info: PluginInfo, fileName: string) {
-    turnOnStrictMode(info, info.project.getCompilerOptions());
-
-    const diagnostics = info.languageService.getSemanticDiagnostics(fileName);
-
-    turnOffStrictMode(info, info.project.getCompilerOptions());
-
-    return diagnostics;
-  }
-
   return { create };
 };
 

sample-project/package-lock.json

@@ -1,5 +1,5 @@
-import * as ts_module from 'typescript/lib/tsserverlibrary';
 import { CompilerOptions } from 'typescript';
+import * as ts_module from 'typescript/lib/tsserverlibrary';
 
 export interface Config {
   paths?: string[];
@@ -8,21 +8,17 @@ export interface Config {
 export type PluginInfo = ts_module.server.PluginCreateInfo;
 
 export function turnOnStrictMode(info: PluginInfo, currentOptions: CompilerOptions): void {
-  if (!currentOptions.strict) {
-    info.project.setCompilerOptions({
-      ...currentOptions,
-      strict: true,
-    });
-  }
+  info.project.setCompilerOptions({
+    ...currentOptions,
+    strict: true,
+  });
 }
 
 export function turnOffStrictMode(info: PluginInfo, currentOptions: CompilerOptions): void {
-  if (currentOptions.strict) {
-    info.project.setCompilerOptions({
-      ...currentOptions,
-      strict: false,
-    });
-  }
+  info.project.setCompilerOptions({
+    ...currentOptions,
+    strict: false,
+  });
 }
 
 export function setupProxy(info: PluginInfo) {