Merge pull request #8 from allegro/fix_windows_paths

Fix windows paths

Author: KostkaBrukowa

.github/workflows/ci.yml

@@ -1,11 +1,14 @@
 name: CI
 
 on:
-  [push, pull_request]
+  [push]
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
+    strategy:     
+      matrix:
+        os: [ubuntu-latest, windows-latest]
 
     steps:
       - uses: actions/checkout@v2

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project
 adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.1.1] - 2021-08-29
+
+### Fixed
+
+- Path features not working on Windows machines
+
 ## [1.1.0] - 2021-06-15
 
 ### Added

e2e/compile-time-tool-tests/compile-time-tool.spec.ts

@@ -1,9 +1,9 @@
 import execa from 'execa';
-import { join } from 'path';
+import path, { join } from 'path';
 
 const runInPath = async (path: string): Promise<string> => {
   const cwd = process.cwd();
-  const cli = join(cwd, 'dist/compile-time-tool/cli.js');
+  const cli = join(cwd, 'dist', 'compile-time-tool', 'cli.js');
 
   process.chdir(path);
   return execa('node', [cli], {
@@ -23,12 +23,12 @@ const runInPath = async (path: string): Promise<string> => {
 
 test('files are detected correctly', async () => {
   jest.setTimeout(20000);
-  const path = process.cwd() + '/e2e/compile-time-tool-tests/repository';
+  const executionPath = path.join(process.cwd(), 'e2e', 'compile-time-tool-tests', 'repository');
 
-  await runInPath(path).then((stdout) => {
+  await runInPath(executionPath).then((stdout) => {
     expect(stdout).toMatch(/notOnPath.ts/);
     expect(stdout).toMatch(/onPath.ts/);
-    expect(stdout).toMatch(/TS2532: Object is possibly 'undefined'/);
+    expect(stdout).toMatch(/TS2532: Object is possibly \\?\\?'undefined\\?\\?'/);
     expect(stdout).toMatch(/Found 2 strict files/);
     expect(stdout).toMatch(/2 errors found/);
   });

e2e/plugin-tests/tests/twoFilesCheckedAtTheSameTime.ts

@@ -25,9 +25,13 @@ function findResponse(responses: ServerResponse[], eventName: string) {
 }
 
 async function run(server: TSServer) {
-  const rootPath = path.resolve(__dirname, '../project-fixture/');
-  const file = path.resolve(__dirname, '../project-fixture/' + 'src/notOnPath.ts');
-  const otherFile = path.resolve(__dirname, '../project-fixture/' + 'src/otherFileNotOnPath.ts');
+  const projectFixture = path.join('..', 'project-fixture');
+  const rootPath = path.resolve(__dirname, projectFixture);
+  const file = path.resolve(__dirname, path.join(projectFixture, 'src', 'notOnPath.ts'));
+  const otherFile = path.resolve(
+    __dirname,
+    path.join(projectFixture, 'src', 'otherFileNotOnPath.ts'),
+  );
 
   // open two files
   server.send({
@@ -62,14 +66,21 @@ async function run(server: TSServer) {
 
   return server.close().then(() => {
     const semanticDiagEvent = findResponse(server.responses, 'semanticDiag');
-    const fileEvent = semanticDiagEvent.filter((it) => it.body.file === file)[0];
-    const otherFileEvent = semanticDiagEvent.filter((it) => it.body.file === otherFile)[0];
+    const fileEvent = semanticDiagEvent.find((it) => toFileSystemSlash(it.body.file) === file);
+    const otherFileEvent = semanticDiagEvent.find(
+      (it) => toFileSystemSlash(it.body.file) === otherFile,
+    );
 
     assert(!!fileEvent);
     assert(!!otherFileEvent);
-    assert.strictEqual(fileEvent.body.diagnostics.length, 1);
-    assert.strictEqual(otherFileEvent.body.diagnostics.length, 0);
+
+    assert.strictEqual(fileEvent!.body.diagnostics.length, 1);
+    assert.strictEqual(otherFileEvent!.body.diagnostics.length, 0);
   });
 }
 
 module.exports = run;
+
+function toFileSystemSlash(file: string): string {
+  return file.split('/').join(path.sep);
+}