Do not throw warning on initial library update

Author: andrew-codechimp

custom_components/battery_notes/__init__.py

@@ -128,7 +128,7 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
 
     library_updater = LibraryUpdater(hass)
     await library_updater.copy_schema()
-    await library_updater.get_library_updates(dt_util.utcnow())
+    await library_updater.get_library_updates(startup=True)
 
     if domain_config.enable_autodiscovery:
         discovery_manager = DiscoveryManager(hass, domain_config)
@@ -180,7 +180,8 @@ async def async_remove_entry(hass: HomeAssistant, config_entry: BatteryNotesConf
     if coordinator.source_entity_id:
         store.async_delete_entity(coordinator.source_entity_id)
     else:
-        store.async_delete_device(coordinator.device_id)
+        if coordinator.device_id:
+            store.async_delete_device(coordinator.device_id)
 
     _LOGGER.debug("Removed battery note %s", config_entry.entry_id)
 

custom_components/battery_notes/config_flow.py

@@ -162,7 +162,7 @@ async def async_step_device(
 
             library_updater = LibraryUpdater(self.hass)
             if await library_updater.time_to_update_library(1):
-                await library_updater.get_library_updates(dt_util.utcnow())
+                await library_updater.get_library_updates()
 
             device_registry = dr.async_get(self.hass)
             device_entry = device_registry.async_get(device_id)
@@ -250,7 +250,7 @@ async def async_step_entity(
 
                     library_updater = LibraryUpdater(self.hass)
                     if await library_updater.time_to_update_library(1):
-                        await library_updater.get_library_updates(dt_util.utcnow())
+                        await library_updater.get_library_updates()
 
                     device_registry = dr.async_get(self.hass)
                     device_entry = device_registry.async_get(entity_entry.device_id)

custom_components/battery_notes/coordinator.py

@@ -188,9 +188,8 @@ def __init__(
                 last_replaced,
             )
 
-            self.last_replaced = (
-                datetime.fromisoformat(last_replaced) if last_replaced else None
-            )
+            if last_replaced:
+                self.last_replaced = datetime.fromisoformat(last_replaced)
 
         # If there is not a last_reported set to now
         if not self.last_reported:

custom_components/battery_notes/library_updater.py

@@ -57,7 +57,7 @@ async def timer_update(self, now: datetime):
         if await self.time_to_update_library(23) is False:
             return
 
-        await self.get_library_updates(now)
+        await self.get_library_updates()
 
         domain_config = self.hass.data[MY_KEY]
 
@@ -68,7 +68,7 @@ async def timer_update(self, now: datetime):
             _LOGGER.debug("Auto discovery disabled")
 
     @callback
-    async def get_library_updates(self, now: datetime):
+    async def get_library_updates(self, startup: bool = False) -> None:
         # pylint: disable=unused-argument
         """Make a call to get the latest library.json."""
 
@@ -97,9 +97,10 @@ def _update_library_json(library_file: str, content: str) -> None:
                 _LOGGER.error("Library file is invalid, not updated")
 
         except LibraryUpdaterClientError:
-            _LOGGER.warning(
-                "Unable to update library, will retry later."
-            )
+            if not startup:
+                _LOGGER.warning(
+                    "Unable to update library, will retry later."
+                )
 
     async def copy_schema(self):
         """Copy schema file to storage to be relative to downloaded library."""