[client] improve default HTTP client

Author: capcom6

src/client.test.ts

@@ -347,7 +347,7 @@ describe('Client', () => {
     describe('Client with JWT Authentication', () => {
         let client: Client;
         let mockHttpClient: HttpClient;
-        const jwtToken = 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ';
+        const jwtToken = 'fake-token-123';
 
         beforeEach(() => {
             mockHttpClient = {
@@ -391,7 +391,7 @@ describe('Client', () => {
                 {
                     "Content-Type": "application/json",
                     "User-Agent": "android-sms-gateway/3.0 (client; js)",
-                    Authorization: `Bearer ${jwtToken}`,
+                    Authorization: `Bearer fake-token-123`,
                 },
             );
             expect(result).toBe(expectedState);
@@ -418,7 +418,7 @@ describe('Client', () => {
                 `${BASE_URL}/message/${messageId}`,
                 {
                     "User-Agent": "android-sms-gateway/3.0 (client; js)",
-                    Authorization: `Bearer ${jwtToken}`,
+                    Authorization: `Bearer fake-token-123`,
                 },
             );
             expect(result).toBe(expectedState);
@@ -533,7 +533,7 @@ describe('Client', () => {
                 ttl: 3600,
             };
             const expectedResponse: TokenResponse = {
-                access_token: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9...',
+                access_token: 'fake-token-123',
                 token_type: 'Bearer',
                 id: 'token-id-123',
                 expires_at: '2024-12-31T23:59:59Z',
@@ -560,7 +560,7 @@ describe('Client', () => {
                 scopes: ['read'],
             };
             const expectedResponse: TokenResponse = {
-                access_token: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9...',
+                access_token: 'fake-token-123',
                 token_type: 'Bearer',
                 id: 'token-id-456',
                 expires_at: '2024-12-31T23:59:59Z',

src/client.ts

@@ -55,39 +55,56 @@ export class Client {
      * Gets the default HTTP client implementation
      */
     private getDefaultHttpClient(): HttpClient {
-        // This would typically be implemented elsewhere, but we'll provide a basic implementation
+        const handleResponse = async (response: Response): Promise<any> => {
+            if (response.status === 204) {
+                return null;
+            }
+
+            if (!response.ok) {
+                const text = await response.text();
+                throw new Error(`HTTP error ${response.status}: ${text}`);
+            }
+
+            const contentType = response.headers.get("Content-Type");
+            if (contentType && contentType.includes("application/json")) {
+                return await response.json();
+            } else {
+                return await response.text();
+            }
+        };
+
         return {
             get: async <T>(url: string, headers?: Record<string, string>): Promise<T> => {
                 const response = await fetch(url, { method: 'GET', headers });
-                return response.json();
+                return handleResponse(response);
             },
             post: async <T>(url: string, body: any, headers?: Record<string, string>): Promise<T> => {
                 const response = await fetch(url, {
                     method: 'POST',
                     headers,
                     body: JSON.stringify(body)
                 });
-                return response.json();
+                return handleResponse(response);
             },
             put: async <T>(url: string, body: any, headers?: Record<string, string>): Promise<T> => {
                 const response = await fetch(url, {
                     method: 'PUT',
                     headers,
                     body: JSON.stringify(body)
                 });
-                return response.json();
+                return handleResponse(response);
             },
             patch: async <T>(url: string, body: any, headers?: Record<string, string>): Promise<T> => {
                 const response = await fetch(url, {
                     method: 'PATCH',
                     headers,
                     body: JSON.stringify(body)
                 });
-                return response.json();
+                return handleResponse(response);
             },
             delete: async <T>(url: string, headers?: Record<string, string>): Promise<T> => {
                 const response = await fetch(url, { method: 'DELETE', headers });
-                return response.json();
+                return handleResponse(response);
             },
         };
     }