Skip to content

Commit 2ffea26

Browse files
committed
Remove arm/v7 support (v3)
1 parent 5ba88c9 commit 2ffea26

File tree

3 files changed

+12
-50
lines changed

3 files changed

+12
-50
lines changed

.github/workflows/docker.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ jobs:
2727
platform:
2828
- linux/amd64
2929
- linux/arm64
30-
- linux/arm/v7
3130
codename:
3231
- focal
3332
- jammy

Dockerfile

Lines changed: 12 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -47,62 +47,30 @@ RUN \
4747
rm -rf CImg
4848

4949
USER builder
50-
ARG TARGETVARIANT
5150

5251
RUN \
5352
export CODENAME=$CODENAME && \
54-
# on arm/v7:
55-
# focal InRelease: The following signatures couldn't be verified because
56-
# the public key is not available: NO_PUBKEY 1A127079A92F09ED
57-
if [ "$TARGETVARIANT" = "v7" ] && [ "$CODENAME" = "focal" ]; then \
58-
sudo apt update && sudo apt install --no-install-recommends -y \
59-
librhash-dev \
60-
libarchive-dev \
61-
libjsoncpp-dev \
62-
libuv1-dev && \
63-
CMAKE_VER=3.31.2 && \
64-
curl -LO https://github.com/Kitware/CMake/releases/download/v$CMAKE_VER/cmake-$CMAKE_VER.tar.gz && \
65-
tar xvf cmake-$CMAKE_VER.tar.gz && \
66-
cd cmake-$CMAKE_VER && \
67-
./bootstrap \
68-
--prefix=/home/builder/.local \
69-
--system-libs \
70-
--no-system-cppdap \
71-
--parallel=$(nproc) && \
72-
make -j $(nproc) && make install && \
73-
cd .. && rm -rf cmake-"$CMAKE_VER" && \
74-
sudo apt remove -y \
75-
librhash-dev \
76-
libarchive-dev \
77-
libjsoncpp-dev \
78-
libuv1-dev && \
79-
rm -rf /var/lib/apt/lists; \
80-
else \
81-
test -f /usr/share/doc/kitware-archive-keyring/copyright || \
82-
wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | sudo tee /usr/share/keyrings/kitware-archive-keyring.gpg >/dev/null && \
83-
echo "deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ $CODENAME main" | sudo tee /etc/apt/sources.list.d/kitware.list >/dev/null && \
84-
sudo apt update && \
85-
sudo apt install -y kitware-archive-keyring && \
86-
echo "deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ $CODENAME-rc main" | sudo tee -a /etc/apt/sources.list.d/kitware.list >/dev/null && \
87-
sudo apt update && \
88-
sudo apt install -y cmake && \
89-
sudo rm -rf /var/lib/apt/lists; \
90-
fi
53+
test -f /usr/share/doc/kitware-archive-keyring/copyright || \
54+
wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | sudo tee /usr/share/keyrings/kitware-archive-keyring.gpg >/dev/null && \
55+
echo "deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ $CODENAME main" | sudo tee /etc/apt/sources.list.d/kitware.list >/dev/null && \
56+
sudo apt update && \
57+
sudo apt install -y kitware-archive-keyring && \
58+
echo "deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ $CODENAME-rc main" | sudo tee -a /etc/apt/sources.list.d/kitware.list >/dev/null && \
59+
sudo apt update && \
60+
sudo apt install -y cmake && \
61+
sudo rm -rf /var/lib/apt/lists
9162

9263
# So pip will not report about the path...
9364
ENV PATH=/home/builder/.local/bin:$PATH
94-
RUN python3 -m pip install pip --upgrade --user
95-
96-
# On arm/v7, pip can't install cmake from source, which is needed to build ninja
97-
RUN python3 -m pip install meson ninja --upgrade --user
65+
RUN \
66+
python3 -m pip install pip --upgrade --user && \
67+
python3 -m pip install meson ninja --upgrade --user
9868

9969
WORKDIR /home/builder
10070

10171
RUN \
10272
git clone --depth 1 --branch 2.0.0-alpha-1-20241106 https://github.com/linuxdeploy/linuxdeploy --recurse-submodules && \
10373
cd linuxdeploy && cp src/core/copyright/copyright.h src/core && \
104-
# On arm/v7, wget fails if --no-check-certificate isn't used
105-
sed -i 's/wget --quiet \"$url\" -O -/curl -o - \"$url\"/g' src/core/generate-excludelist.sh && \
10674
cmake . \
10775
-G Ninja \
10876
-DCMAKE_INSTALL_PREFIX=$HOME/.local \
@@ -167,8 +135,6 @@ RUN \
167135
https://github.com/linuxdeploy/linuxdeploy-plugin-qt \
168136
--recurse-submodules && \
169137
cd linuxdeploy-plugin-qt && \
170-
# On arm/v7, wget fails if --no-check-certificate isn't used
171-
sed -i 's/wget --quiet \"$url\" -O -/curl -o - \"$url\"/g' lib/linuxdeploy/src/core/generate-excludelist.sh && \
172138
cmake . \
173139
-G Ninja \
174140
-DBUILD_GMOCK=OFF \

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ version Ubuntu.
1313

1414
amd64
1515
arm64
16-
arm/v7
17-
18-
(The appimage plugin doesn't yet support 'ppc64le' or 's390x')
1916

2017
## Usage
2118

0 commit comments

Comments
 (0)