Merge pull request #2464 from blokfyuh/blokfyuh-hash-fix-permissions-plugins

fix(transitionTo): re-added the saved hash before broadcasting event

Author: nateabele

src/state.js

@@ -1048,7 +1048,10 @@ function $StateProvider(   $urlRouterProvider,   $urlMatcherFactory) {
 
       // Filter parameters before we pass them to event handlers etc.
       toParams = filterByKeys(to.params.$$keys(), toParams || {});
-
+      
+      // Re-add the saved hash before we start returning things or broadcasting $stateChangeStart
+      if (hash) toParams['#'] = hash;
+      
       // Broadcast start event and cancel the transition if requested
       if (options.notify) {
         /**
@@ -1126,9 +1129,6 @@ function $StateProvider(   $urlRouterProvider,   $urlMatcherFactory) {
           }
         }
 
-        // Re-add the saved hash before we start returning things
-        if (hash) toParams['#'] = hash;
-
         // Run it again, to catch any transitions in callbacks
         if ($state.transition !== transition) return TransitionSuperseded;
 

test/stateSpec.js

@@ -570,6 +570,18 @@ describe('state', function () {
       expect($location.url()).toBe('/front/world#frag');
       expect($location.hash()).toBe('frag');
     }));
+    
+    it('has access to the #fragment in $stateChangeStart hook', inject(function ($state, $q, $location, $rootScope) {
+        var hash_accessible = false;
+        $rootScope.$on('$stateChangeStart', function (event, toState, toParams, fromState, fromParams) {
+            hash_accessible = toParams['#'] === 'frag';
+        });
+        
+        $state.transitionTo('home.item', {id: 'world', '#': 'frag'});
+        $q.flush();
+        
+        expect(hash_accessible).toBe(true);
+    }));
   });
 
   describe('.go()', function () {