build: fix gulp setup not working with node v12 (#1142)

See angular/angular#33348

Fixes #1079

Author: CaerusKaru

.circleci/config.yml

@@ -9,7 +9,7 @@
 # To validate changes, use an online parser, eg.
 # http://yaml-online-parser.appspot.com/
 
-var_1: &docker_image angular/ngcontainer:0.7.0
+var_1: &docker_image circleci/node:12.9.1
 var_2: &cache_key v2-ng-layout-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.7.0
 
 # Settings common to each job
@@ -53,14 +53,22 @@ var_8: &docker-firefox-image
   # TODO(devversion): Temporarily use a image that includes Firefox 62 because the
   # ngcontainer image does include an old Firefox version that does not support headless.
   # See the PR that fixes this: https://github.com/angular/angular/pull/26435
-  - image: circleci/node:10.12-browsers
+  - image: circleci/node:12.9.1-browsers
 
 # Attaches the release output which has been stored in the workspace to the current job.
 # https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
 var_9: &attach_release_output
   attach_workspace:
     at: dist/releases
 
+# Anchor that can be used to download and install Yarn globally in the bash environment.
+var_10: &yarn_download
+  run:
+    name: "Downloading and installing Yarn"
+    command: |
+      touch $BASH_ENV
+      curl -o- -L https://yarnpkg.com/install.sh | PROFILE=$BASH_ENV bash -s -- --version "1.19.1"
+
 # -----------------------------
 # Container version of CircleCI
 # -----------------------------
@@ -80,6 +88,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: yarn gulp :publish:build-releases
@@ -97,6 +106,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: ./scripts/circleci/run-local-browser-tests.sh
@@ -113,6 +123,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: ./scripts/circleci/run-browserstack-tests.sh
@@ -132,6 +143,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: ./scripts/circleci/run-saucelabs-tests.sh
@@ -144,6 +156,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: yarn gulp ci:ssr
@@ -157,6 +170,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: yarn gulp ci:prerender
@@ -169,6 +183,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: yarn gulp ci:hw
@@ -181,6 +196,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: yarn gulp ci:aot
@@ -193,6 +209,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: yarn gulp ci:lint
@@ -206,6 +223,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: yarn gulp ci:build-release-packages
@@ -251,6 +269,7 @@ jobs:
 
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
       - *attach_release_output
 

package.json

@@ -10,7 +10,8 @@
   },
   "license": "MIT",
   "engines": {
-    "node": ">= 5.4.1"
+    "node": "^12.0.0",
+    "yarn": ">= 1.19.1"
   },
   "scripts": {
     "demo:serve": "gulp serve:devapp",
@@ -49,7 +50,7 @@
     "@angular/platform-browser-dynamic": "^8.0.0-rc.5",
     "@angular/platform-server": "^8.0.0-rc.5",
     "@angular/router": "^8.0.0-rc.5",
-    "@google-cloud/storage": "^1.7.0",
+    "@firebase/app-types": "^0.3.2",
     "@types/chalk": "^0.4.31",
     "@types/fs-extra": "^4.0.5",
     "@types/glob": "^5.0.33",
@@ -66,8 +67,6 @@
     "cli-color": "^1.4.0",
     "dgeni": "^0.4.10",
     "dgeni-packages": "^0.26.12",
-    "firebase": "^5.5.8",
-    "firebase-admin": "^5.13.1",
     "firebase-tools": "^4.2.1",
     "fs-extra": "^3.0.1",
     "git-semver-tags": "^2.0.2",
@@ -122,5 +121,9 @@
     "tslint": "^5.11.0",
     "typescript": "~3.4.5",
     "uglify-js": "^2.8.14"
+  },
+  "// Gulp": "Overwrite graceful-fs to a version that does not rely on the 'natives' package. This fixes gulp for >= 10.13, more information: #28213",
+  "resolutions": {
+    "**/graceful-fs": "4.2.2"
   }
 }

src/apps/demo-app/package.json

@@ -14,7 +14,7 @@
   "dependencies": {
     "@angular/animations": "file:../../../node_modules/@angular/animations",
     "@angular/cdk": "file:../../../node_modules/@angular/cdk",
-    "@angular/cli": "^8.0.0-rc.4",
+    "@angular/cli": "^8.3.17",
     "@angular/common": "file:../../../node_modules/@angular/common",
     "@angular/compiler": "file:../../../node_modules/@angular/compiler",
     "@angular/core": "file:../../../node_modules/@angular/core",
@@ -30,9 +30,9 @@
     "zone.js": "file:../../../node_modules/zone.js"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "~0.800.0-rc.4",
+    "@angular-devkit/build-angular": "~0.803.17",
     "@angular/compiler-cli": "file:../../../node_modules/@angular/compiler-cli",
-    "@angular/language-service": "^8.0.0-rc.5",
+    "@angular/language-service": "^8.2.13",
     "@types/jasmine": "~2.8.3",
     "@types/jasminewd2": "~2.0.2",
     "@types/node": "~6.0.60",

src/apps/hello-world/package.json

@@ -14,7 +14,7 @@
   "dependencies": {
     "@angular/animations": "file:../../../node_modules/@angular/animations",
     "@angular/cdk": "file:../../../node_modules/@angular/cdk",
-    "@angular/cli": "^8.0.0-rc.4",
+    "@angular/cli": "^8.3.17",
     "@angular/common": "file:../../../node_modules/@angular/common",
     "@angular/compiler": "file:../../../node_modules/@angular/compiler",
     "@angular/core": "file:../../../node_modules/@angular/core",
@@ -29,9 +29,9 @@
     "zone.js": "file:../../../node_modules/zone.js"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "~0.800.0-rc.4",
+    "@angular-devkit/build-angular": "~0.803.17",
     "@angular/compiler-cli": "file:../../../node_modules/@angular/compiler-cli",
-    "@angular/language-service": "^8.0.0-rc.5",
+    "@angular/language-service": "^8.2.13",
     "typescript": "file:../../../node_modules/typescript"
   }
 }

src/apps/universal-app/package.json

@@ -26,18 +26,18 @@
     "@angular/platform-browser-dynamic": "file:../../../node_modules/@angular/platform-browser-dynamic",
     "@angular/platform-server": "file:../../../node_modules/@angular/platform-server",
     "@angular/router": "file:../../../node_modules/@angular/router",
-    "@nguniversal/express-engine": "^8.0.0-rc.0",
+    "@nguniversal/express-engine": "^8.1.1",
     "core-js": "^2.5.4",
     "express": "^4.16.2",
     "rxjs": "~6.5.2",
     "tslib": "^1.9.0",
     "zone.js": "~0.9.1"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "~0.800.0-rc.4",
-    "@angular/cli": "~8.0.0-rc.4",
+    "@angular-devkit/build-angular": "~0.803.17",
+    "@angular/cli": "~8.3.17",
     "@angular/compiler-cli": "file:../../../node_modules/@angular/compiler-cli",
-    "@angular/language-service": "~8.0.0-rc.5",
+    "@angular/language-service": "~8.2.13",
     "@types/node": "~8.9.4",
     "@types/jasmine": "~2.8.8",
     "@types/jasminewd2": "~2.0.3",

src/lib/grid/auto/auto.spec.ts

@@ -155,7 +155,7 @@ describe('grid auto parent directive', () => {
 
       expectNativeEl(fixture).toHaveStyle({
         'display': 'grid',
-        'grid-auto-flow': (platform.FIREFOX || platform.EDGE) ? 'row dense' : 'dense'
+        'grid-auto-flow': platform.EDGE ? 'row dense' : 'dense'
       }, styler);
     });
 
@@ -175,7 +175,7 @@ describe('grid auto parent directive', () => {
 
       expectNativeEl(fixture).toHaveStyle({
         'display': 'grid',
-        'grid-auto-flow': (platform.FIREFOX || platform.EDGE) ? 'row dense' : 'dense'
+        'grid-auto-flow': platform.EDGE ? 'row dense' : 'dense'
       }, styler);
     });
 
@@ -215,7 +215,7 @@ describe('grid auto parent directive', () => {
 
       expectNativeEl(fixture).toHaveStyle({
         'display': 'grid',
-        'grid-auto-flow': 'row dense'
+        'grid-auto-flow': platform.FIREFOX ? 'dense' : 'row dense',
       }, styler);
     });
 
@@ -235,7 +235,7 @@ describe('grid auto parent directive', () => {
 
       expectNativeEl(fixture).toHaveStyle({
         'display': 'grid',
-        'grid-auto-flow': 'row dense'
+        'grid-auto-flow': platform.FIREFOX ? 'dense' : 'row dense'
       }, styler);
     });
 

tools/gulp/tasks/universal.ts

@@ -54,12 +54,12 @@ task('prerender:bundle:rename', [], execTask(
 
 /** Task that builds the universal-app in server mode */
 task('prerender:build', execTask(
-  'npm', ['run', 'build:ssr:bundle'],
+  'yarn', ['build:ssr:bundle'],
   {cwd: universalAppSource, failOnStderr: true}
 ));
 
 task('prerender:webpack', execTask(
-  'npm', ['run', 'build:server'],
+  'yarn', ['build:server'],
   {cwd: universalAppSource}
 ));