Skip to content

Commit 6845579

Browse files
committed
fix: minor style fixes
* Fixes that the neutral color for bar chars was blending into the background. * Uses a different icon for tests. * Removes text selection when clicking on the bar chart.
1 parent 83d41ea commit 6845579

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

report-app/src/app/pages/report-viewer/report-viewer.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ <h3>Runner</h3>
6666
<div class="charts-grid">
6767
<div class="chart-container build-results-details">
6868
<h3 class="chart-title">
69-
<span class="material-symbols-outlined"> build </span>
69+
<span class="material-symbols-outlined">build</span>
7070
<span>Build</span>
7171
</h3>
7272
<div class="summary-card-item">
@@ -76,7 +76,7 @@ <h3 class="chart-title">
7676
@if (overview.stats.tests) {
7777
<div class="chart-container test-results-details">
7878
<h3 class="chart-title">
79-
<span class="material-symbols-outlined"> quiz </span>
79+
<span class="material-symbols-outlined">assignment</span>
8080
<span>Tests</span>
8181
</h3>
8282
<div class="summary-card-item">
@@ -87,7 +87,7 @@ <h3 class="chart-title">
8787
@if (overview.stats.runtime) {
8888
<div class="chart-container">
8989
<h3 class="chart-title">
90-
<span class="material-symbols-outlined"> schedule </span>
90+
<span class="material-symbols-outlined">schedule</span>
9191
<span>Runtime</span>
9292
</h3>
9393
<div class="summary-card-item">
@@ -101,7 +101,7 @@ <h3 class="chart-title">
101101
@if (overview.stats.security) {
102102
<div class="chart-container">
103103
<h3 class="chart-title">
104-
<span class="material-symbols-outlined"> security </span>
104+
<span class="material-symbols-outlined">security</span>
105105
<span>Security</span>
106106
</h3>
107107
<div class="summary-card-item">

report-app/src/app/shared/visualization/stacked-bar-chart/stacked-bar-chart.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
font-weight: 500;
3838
transition: filter 0.2s ease-in-out;
3939
min-width: 50px;
40+
user-select: none;
4041

4142
&:first-child {
4243
border-top-left-radius: 8px;

report-app/src/styles.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
--status-fill-great: #84cc16;
3131
--status-fill-good: #f59e0b;
3232
--status-fill-poor: #ef4444;
33-
--status-fill-neutral: #eff6ff;
33+
--status-fill-neutral: #aaa;
3434

3535
--status-text-excellent: #0c855d;
3636
--status-text-great: #0c855d; // TODO: do we want to differentiate from `excellent`?

0 commit comments

Comments
 (0)