Change warning to failure on firewall config timeout

[jdewinne]

SUMMARY

To be consistent with other module.fail_json usage when updating the firewall times out.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

community.hrobot

ADDITIONAL INFORMATION

There are 2 paths where a firewall timeout can happen. If a timeout occurs, the code should fail and not just warn.

[felixfontein]

I'm OK with making this configurable, but I don't see why this should be a failure by default. Can you please elaborate on why you think this should be a failure?

[jdewinne]

I'm OK with making this configurable, but I don't see why this should be a failure by default. Can you please elaborate on why you think this should be a failure?

Same is done on L624

[felixfontein]

That is a very different situation: there the module is waiting for the firewall to be in a state where it can be configured. In the other situation, which you are changing, the configuration has already been applied, and the module is waiting for it to become active.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (8f4cd53) to head (ee1cc9c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   99.89%   99.89%   -0.01%     
==========================================
  Files          61       61              
  Lines        4757     4750       -7     
  Branches      525      525              
==========================================
- Hits         4752     4745       -7     
  Misses          2        2              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.