Skip to content

Commit 45ead1e

Browse files
fix(launcher): relax stdout check for gRPC server startup (#4299)
* fix(launcher): relax stdout check for gRPC server startup Match "GRPC SERVER" (instead of the stricter "START GRPC SERVER") when detecting MAPDL's "Server listening on" output. This makes the startup detection more robust to variations in MAPDL log messages. * chore: adding changelog file 4299.fixed.md [dependabot-skip] * chore(ci): include git in apt installs for test-local workflow --------- Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
1 parent e6ca79f commit 45ead1e

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/test-local.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,13 +186,13 @@ jobs:
186186
shell: bash
187187
if: inputs.testing-minimal == true
188188
run: |
189-
apt-get update && apt install -y libgomp1 graphviz curl && apt-get clean
189+
apt-get update && apt install -y libgomp1 graphviz curl git && apt-get clean
190190
191191
- name: "Installing OS packages"
192192
shell: bash
193193
if: inputs.testing-minimal == false
194194
run: |
195-
apt-get update && apt install -y libgl1 libglx-mesa0 xvfb libgomp1 graphviz curl && apt-get clean
195+
apt-get update && apt install -y libgl1 libglx-mesa0 xvfb libgomp1 graphviz curl git && apt-get clean
196196
197197
- name: "Setup Python"
198198
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c #v6.0.0

doc/changelog.d/4299.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Relax stdout check for gRPC server startup

src/ansys/mapdl/core/launcher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -730,7 +730,7 @@ def _check_server_is_alive(stdout_queue: QueueWithStorage, timeout: int):
730730
continue
731731

732732
if (
733-
"START GRPC SERVER" in terminal_output
733+
"GRPC SERVER" in terminal_output
734734
and "Server listening on" in terminal_output
735735
):
736736
listening_on = terminal_output.splitlines()[-1]

0 commit comments

Comments
 (0)