Skip to content

Commit de4d9d5

Browse files
Fixed unit test error
1 parent 643abee commit de4d9d5

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>io.github.delirius325</groupId>
55
<artifactId>jmeter.backendlistener.elasticsearch</artifactId>
6-
<version>2.5.0</version>
6+
<version>2.5.1-SNAPSHOT</version>
77
<packaging>jar</packaging>
88

99
<name>jmeter.backendlistener.elasticsearch</name>

src/main/java/io/github/delirius325/jmeter/backendlistener/elasticsearch/ElasticSearchMetric.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,15 @@ public class ElasticSearchMetric {
2222
private String esTimestamp;
2323
private int ciBuildNumber;
2424
private HashMap<String, Object> json;
25+
private boolean all;
2526

26-
public ElasticSearchMetric(SampleResult sr, String testMode, String timeStamp, int buildNumber) {
27+
public ElasticSearchMetric(SampleResult sr, String testMode, String timeStamp, int buildNumber, boolean parseHeaders) {
2728
this.sampleResult = sr;
2829
this.esTestMode = testMode.trim();
2930
this.esTimestamp = timeStamp.trim();
3031
this.ciBuildNumber = buildNumber;
3132
this.json = new HashMap<>();
33+
this.all = parseHeaders;
3234
}
3335

3436
/**
@@ -79,7 +81,7 @@ public Map<String, Object> getMetric(BackendListenerContext context) throws Exce
7981
addAssertions();
8082
addElapsedTime(sdf);
8183
addCustomFields(context);
82-
checkCustomVariables();
84+
parseHeadersAsDocumentProps(this.all);
8385

8486
return this.json;
8587
}
@@ -181,7 +183,7 @@ private void parseHeadersAsDocumentProps(boolean all) {
181183

182184
for(int i=0; i < lines.length; i++) {
183185
String[] header = lines[i].split(":");
184-
if(!all) {
186+
if(!this.all) {
185187
if(header[0].startsWith("X-es-backend")) {
186188
this.json.put(header[0].replaceAll("es-", "").trim(), header[1].trim());
187189
}

src/main/java/io/github/delirius325/jmeter/backendlistener/elasticsearch/ElasticsearchBackendClient.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public class ElasticsearchBackendClient extends AbstractBackendListenerClient {
2727
private static final String ES_TEST_MODE = "es.test.mode";
2828
private static final String ES_AUTH_USER = "es.xpack.user";
2929
private static final String ES_AUTH_PWD = "es.xpack.password";
30+
private static final String ES_PARSE_HEADERS = "es.parse.all.headers";
3031
private static final long DEFAULT_TIMEOUT_MS = 200L;
3132
private static final Logger logger = LoggerFactory.getLogger(ElasticsearchBackendClient.class);
3233

@@ -52,6 +53,7 @@ public Arguments getDefaultParameters() {
5253
parameters.addArgument(ES_TEST_MODE, "info");
5354
parameters.addArgument(ES_AUTH_USER, "");
5455
parameters.addArgument(ES_AUTH_PWD, "");
56+
parameters.addArgument(ES_PARSE_HEADERS, "false");
5557
return parameters;
5658
}
5759

@@ -96,7 +98,7 @@ public void onFailure(Node node) {
9698
@Override
9799
public void handleSampleResults(List<SampleResult> results, BackendListenerContext context) {
98100
for(SampleResult sr : results) {
99-
ElasticSearchMetric metric = new ElasticSearchMetric(sr, context.getParameter(ES_TEST_MODE), context.getParameter(ES_TIMESTAMP), this.buildNumber);
101+
ElasticSearchMetric metric = new ElasticSearchMetric(sr, context.getParameter(ES_TEST_MODE), context.getParameter(ES_TIMESTAMP), this.buildNumber, context.getBooleanParameter(ES_PARSE_HEADERS, false));
100102

101103
if(validateSample(context, sr)) {
102104
try {

src/test/java/io/github/delirius325/jmeter/backendlistener/elasticsearch/TestElasticSearchBackend.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ public class TestElasticSearchBackend {
1717

1818
@Before
1919
public void setUp() throws Exception {
20-
metricCI = new ElasticSearchMetric(new SampleResult(), "info", "yyyy-MM-dd'T'HH:mm:ss.SSSZZ", 1);
21-
metricNoCI = new ElasticSearchMetric(new SampleResult(), "info", "yyyy-MM-dd'T'HH:mm:ss.SSSZZ", 0);
20+
metricCI = new ElasticSearchMetric(new SampleResult(), "info", "yyyy-MM-dd'T'HH:mm:ss.SSSZZ", 1, false);
21+
metricNoCI = new ElasticSearchMetric(new SampleResult(), "info", "yyyy-MM-dd'T'HH:mm:ss.SSSZZ", 0, false);
2222
}
2323

2424
@Test

0 commit comments

Comments
 (0)