From 0dd21f03d9175eadeeb527979354689a1c0c7cdc Mon Sep 17 00:00:00 2001 From: MaxymVlasov Date: Fri, 28 Nov 2025 18:55:11 +0200 Subject: [PATCH 1/2] fix(`terraform_providers_lock`): Log in which folder hook failed --- hooks/terraform_providers_lock.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hooks/terraform_providers_lock.sh b/hooks/terraform_providers_lock.sh index 9a4d1b624..138c9a8cf 100755 --- a/hooks/terraform_providers_lock.sh +++ b/hooks/terraform_providers_lock.sh @@ -157,8 +157,14 @@ Check migration instructions at https://github.com/antonbabenko/pre-commit-terra # pass the arguments to hook "$tf_path" providers lock "${args[@]}" - # return exit code to common::per_dir_hook exit_code=$? + if [[ $exit_code != 0 ]]; then + common::colorify "red" "$dir_path run failed. Detailed error above. +Most common issue is that you didn't run requiring 'terraform init' before running this hook. It can be run by 'terraform_validate' hook - https://github.com/antonbabenko/pre-commit-terraform#terraform_validate +" + fi + + # return exit code to common::per_dir_hook return $exit_code } From f74b9d750396da7ac2b40b99d72d80759576e1ba Mon Sep 17 00:00:00 2001 From: Maksym Vlasov Date: Fri, 28 Nov 2025 22:26:26 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: George Yermulnik (Georgii Iermulnik) --- hooks/terraform_providers_lock.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hooks/terraform_providers_lock.sh b/hooks/terraform_providers_lock.sh index 138c9a8cf..867e76053 100755 --- a/hooks/terraform_providers_lock.sh +++ b/hooks/terraform_providers_lock.sh @@ -158,9 +158,9 @@ Check migration instructions at https://github.com/antonbabenko/pre-commit-terra "$tf_path" providers lock "${args[@]}" exit_code=$? - if [[ $exit_code != 0 ]]; then + if [[ $exit_code -ne 0 ]]; then common::colorify "red" "$dir_path run failed. Detailed error above. -Most common issue is that you didn't run requiring 'terraform init' before running this hook. It can be run by 'terraform_validate' hook - https://github.com/antonbabenko/pre-commit-terraform#terraform_validate +Most common issue is that required 'terraform init' command was likely not run before running this hook. It might be run for you automatically by 'terraform_validate' hook - see https://github.com/antonbabenko/pre-commit-terraform#terraform_validate for more details " fi