chore: enforce clippy::allow_attributes for datasource crates (#19068)

## Which issue does this PR close?

Part of #18881

## Rationale for this change

Implement clippy::allow_attributes lint for datasource* crates

## What changes are included in this PR?

1. Added lint enforcement: `#![deny(clippy::allow_attributes)]` to 6
datasource module mod.rs files
2. Attribute conversion: Changed 3 `#[allow(...)]` to `#[expect(...)]`:
    - deprecated
    - unused_imports
    - rustdoc::broken_intra_doc_links

## Are these changes tested?

yes

## Are there any user-facing changes?

No user-facing changes.

---------

Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>

Author: chakkk309

datafusion/datasource-arrow/src/mod.rs

@@ -19,6 +19,7 @@
 // Make sure fast / cheap clones on Arc are explicit:
 // https://github.com/apache/datafusion/issues/11143
 #![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
+#![deny(clippy::allow_attributes)]
 
 //! [`ArrowFormat`]: Apache Arrow file format abstractions
 

datafusion/datasource-avro/src/mod.rs

@@ -24,6 +24,7 @@
 // https://github.com/apache/datafusion/issues/11143
 #![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
 #![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+#![deny(clippy::allow_attributes)]
 
 //! An [Avro](https://avro.apache.org/) based [`FileSource`](datafusion_datasource::file::FileSource) implementation and related functionality.
 

datafusion/datasource-csv/src/mod.rs

@@ -19,6 +19,7 @@
 // Make sure fast / cheap clones on Arc are explicit:
 // https://github.com/apache/datafusion/issues/11143
 #![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
+#![deny(clippy::allow_attributes)]
 
 pub mod file_format;
 pub mod source;

datafusion/datasource-json/src/mod.rs

@@ -19,6 +19,7 @@
 // Make sure fast / cheap clones on Arc are explicit:
 // https://github.com/apache/datafusion/issues/11143
 #![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
+#![deny(clippy::allow_attributes)]
 
 pub mod file_format;
 pub mod source;

datafusion/datasource-parquet/src/mod.rs

@@ -19,6 +19,7 @@
 // https://github.com/apache/datafusion/issues/11143
 #![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
 #![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+#![deny(clippy::allow_attributes)]
 
 pub mod access_plan;
 pub mod file_format;

datafusion/datasource-parquet/src/opener.rs

@@ -584,7 +584,6 @@ where
 }
 
 #[derive(Default)]
-#[cfg_attr(not(feature = "parquet_encryption"), allow(dead_code))]
 struct EncryptionContext {
     #[cfg(feature = "parquet_encryption")]
     file_decryption_properties: Option<Arc<FileDecryptionProperties>>,
@@ -626,7 +625,7 @@ impl EncryptionContext {
 }
 
 #[cfg(not(feature = "parquet_encryption"))]
-#[allow(dead_code)]
+#[expect(dead_code)]
 impl EncryptionContext {
     async fn get_file_decryption_properties(
         &self,
@@ -646,7 +645,7 @@ impl ParquetOpener {
     }
 
     #[cfg(not(feature = "parquet_encryption"))]
-    #[allow(dead_code)]
+    #[expect(dead_code)]
     fn get_encryption_context(&self) -> EncryptionContext {
         EncryptionContext::default()
     }

datafusion/datasource-parquet/src/reader.rs

@@ -289,7 +289,8 @@ impl AsyncFileReader for CachedParquetFileReader {
 
     fn get_metadata<'a>(
         &'a mut self,
-        #[allow(unused_variables)] options: Option<&'a ArrowReaderOptions>,
+        #[cfg_attr(not(feature = "parquet_encryption"), expect(unused_variables))]
+        options: Option<&'a ArrowReaderOptions>,
     ) -> BoxFuture<'a, parquet::errors::Result<Arc<ParquetMetaData>>> {
         let object_meta = self.partitioned_file.object_meta.clone();
         let metadata_cache = Arc::clone(&self.metadata_cache);

datafusion/datasource-parquet/src/source.rs

@@ -803,7 +803,7 @@ mod tests {
     use datafusion_physical_expr::expressions::lit;
 
     #[test]
-    #[allow(deprecated)]
+    #[expect(deprecated)]
     fn test_parquet_source_predicate_same_as_filter() {
         let predicate = lit(true);
 

datafusion/datasource/src/file_scan_config.rs

@@ -19,8 +19,6 @@
 //! file sources.
 
 use crate::file_groups::FileGroup;
-#[allow(unused_imports)]
-use crate::schema_adapter::SchemaAdapterFactory;
 use crate::{
     display::FileGroupsDisplay, file::FileSource,
     file_compression_type::FileCompressionType, file_stream::FileStream,

datafusion/datasource/src/file_stream.rs

@@ -354,7 +354,6 @@ impl StartableTime {
     }
 }
 
-#[allow(rustdoc::broken_intra_doc_links)]
 /// Metrics for [`FileStream`]
 ///
 /// Note that all of these metrics are in terms of wall clock time