Skip to content

Commit 08360f3

Browse files
committed
Merge remote-tracking branch 'origin/claude/add-unit-tests-011CUpCCHrzB7YG4Mx8jAUdF' into claude/add-unit-tests-011CUpCCHrzB7YG4Mx8jAUdF
2 parents 19b8968 + 8f0c04c commit 08360f3

File tree

2 files changed

+20
-42
lines changed

2 files changed

+20
-42
lines changed

server/src/test/java/org/apache/seata/server/cluster/raft/sync/msg/RaftVGroupSyncMsgTest.java

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@
1818

1919
import org.apache.seata.core.store.MappingDO;
2020
import org.junit.jupiter.api.Test;
21-
import java.io.ByteArrayInputStream;
22-
import java.io.ByteArrayOutputStream;
23-
import java.io.ObjectInputStream;
24-
import java.io.ObjectOutputStream;
2521

2622
import static org.junit.jupiter.api.Assertions.*;
2723

@@ -58,27 +54,16 @@ public void testSetAndGetMappingDO() {
5854
}
5955

6056
@Test
61-
public void testSerialization() throws Exception {
57+
public void testGettersAndSetters() {
58+
RaftVGroupSyncMsg msg = new RaftVGroupSyncMsg();
6259
MappingDO mappingDO = new MappingDO();
6360
mappingDO.setVGroup("test-vgroup");
6461
mappingDO.setCluster("test-cluster");
65-
RaftVGroupSyncMsg original = new RaftVGroupSyncMsg(mappingDO, RaftSyncMsgType.REMOVE_VGROUP_MAPPING);
66-
67-
// Serialize
68-
ByteArrayOutputStream bos = new ByteArrayOutputStream();
69-
ObjectOutputStream oos = new ObjectOutputStream(bos);
70-
oos.writeObject(original);
71-
oos.flush();
72-
byte[] serialized = bos.toByteArray();
73-
74-
// Deserialize
75-
ByteArrayInputStream bis = new ByteArrayInputStream(serialized);
76-
ObjectInputStream ois = new ObjectInputStream(bis);
77-
RaftVGroupSyncMsg deserialized = (RaftVGroupSyncMsg) ois.readObject();
62+
msg.setMappingDO(mappingDO);
63+
msg.setMsgType(RaftSyncMsgType.UPDATE_VGROUP_MAPPING);
7864

79-
// Verify
80-
assertEquals(original.getMsgType(), deserialized.getMsgType());
81-
assertEquals(original.getMappingDO().getVGroup(), deserialized.getMappingDO().getVGroup());
82-
assertEquals(original.getMappingDO().getCluster(), deserialized.getMappingDO().getCluster());
65+
assertEquals(RaftSyncMsgType.UPDATE_VGROUP_MAPPING, msg.getMsgType());
66+
assertEquals("test-vgroup", msg.getMappingDO().getVGroup());
67+
assertEquals("test-cluster", msg.getMappingDO().getCluster());
8368
}
8469
}

server/src/test/java/org/apache/seata/server/cluster/raft/sync/msg/dto/RaftClusterMetadataTest.java

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@
1818

1919
import org.apache.seata.common.metadata.Node;
2020
import org.junit.jupiter.api.Test;
21-
import java.io.ByteArrayInputStream;
22-
import java.io.ByteArrayOutputStream;
23-
import java.io.ObjectInputStream;
24-
import java.io.ObjectOutputStream;
2521
import java.util.Arrays;
2622

2723
import static org.junit.jupiter.api.Assertions.*;
@@ -86,25 +82,22 @@ public void testToString() {
8682
}
8783

8884
@Test
89-
public void testSerialization() throws Exception {
90-
RaftClusterMetadata original = new RaftClusterMetadata(456L);
85+
public void testNodeListManagement() {
86+
RaftClusterMetadata metadata = new RaftClusterMetadata(100L);
87+
9188
Node leader = new Node();
92-
original.setLeader(leader);
89+
metadata.setLeader(leader);
90+
assertNotNull(metadata.getLeader());
9391

94-
// Serialize
95-
ByteArrayOutputStream bos = new ByteArrayOutputStream();
96-
ObjectOutputStream oos = new ObjectOutputStream(bos);
97-
oos.writeObject(original);
98-
oos.flush();
99-
byte[] serialized = bos.toByteArray();
92+
Node follower1 = new Node();
93+
Node follower2 = new Node();
94+
metadata.setFollowers(Arrays.asList(follower1, follower2));
95+
assertEquals(2, metadata.getFollowers().size());
10096

101-
// Deserialize
102-
ByteArrayInputStream bis = new ByteArrayInputStream(serialized);
103-
ObjectInputStream ois = new ObjectInputStream(bis);
104-
RaftClusterMetadata deserialized = (RaftClusterMetadata) ois.readObject();
97+
Node learner = new Node();
98+
metadata.setLearner(Arrays.asList(learner));
99+
assertEquals(1, metadata.getLearner().size());
105100

106-
// Verify
107-
assertEquals(original.getTerm(), deserialized.getTerm());
108-
assertNotNull(deserialized.getLeader());
101+
assertEquals(100L, metadata.getTerm());
109102
}
110103
}

0 commit comments

Comments
 (0)