Skip to content

Commit cf89daa

Browse files
authored
Update GH CI (#1658)
As test was naively using `new File("")` assuming its method `file.list()` will return `null` on cleanup in `teardown()` method. But, it turns out it was an old Java bug fixed in Java 25, and once GH matrix got Java 25 introduced, it broke the build. Refs: * https://bugs.openjdk.org/browse/JDK-8024695 * https://inside.java/2025/11/03/quality-heads-up/ Thanks to @sormuras
1 parent 87d05bf commit cf89daa

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.github/workflows/maven-verify.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
with:
2929
ff-run: false
3030
ff-site-run: false
31-
jdk-matrix: '[ "21" ]'
32-
maven-matrix: '[ "3.9.11", "4.0.0-rc-4" ]'
31+
maven4-enabled: true
3332
verify-fail-fast: false
34-
33+
jdk-matrix: '[ "21", "25" ]'

maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -772,7 +772,7 @@ void testFindInLocalRepositoryWhenVersionWasFoundInLocalRepository() throws Arti
772772
session.setLocalRepositoryManager(new LocalRepositoryManager() {
773773

774774
public LocalRepository getRepository() {
775-
return new LocalRepository(new File(""));
775+
return new LocalRepository(lrm.getRepository().getBasePath());
776776
}
777777

778778
public String getPathForRemoteMetadata(Metadata metadata, RemoteRepository repository, String context) {
@@ -841,7 +841,7 @@ void testFindInLocalRepositoryWhenVersionRangeWasResolvedFromLocalRepository() t
841841
session.setLocalRepositoryManager(new LocalRepositoryManager() {
842842

843843
public LocalRepository getRepository() {
844-
return new LocalRepository(new File(""));
844+
return new LocalRepository(lrm.getRepository().getBasePath());
845845
}
846846

847847
public String getPathForRemoteMetadata(Metadata metadata, RemoteRepository repository, String context) {

0 commit comments

Comments
 (0)