chore: add param type (#7313)

Author: VincentLanglet

phpstan.neon.dist

@@ -149,7 +149,6 @@ parameters:
 				- src/Symfony/Bundle/Test
 				- src/Symfony/Tests
 				- tests
-				- src # TODO
 		-
 			identifier: missingType.return
 			paths:

src/Doctrine/Common/Filter/BackedEnumFilterTrait.php

@@ -89,7 +89,7 @@ abstract protected function normalizePropertyName(string $property): string;
      */
     abstract protected function isBackedEnumField(string $property, string $resourceClass): bool;
 
-    private function normalizeValue($value, string $property): mixed
+    private function normalizeValue(mixed $value, string $property): mixed
     {
         $firstCase = $this->enumTypes[$property]::cases()[0] ?? null;
         if (

src/Doctrine/Common/Filter/BooleanFilterTrait.php

@@ -75,7 +75,7 @@ protected function isBooleanField(string $property, string $resourceClass): bool
         return isset(self::DOCTRINE_BOOLEAN_TYPES[(string) $this->getDoctrineFieldType($property, $resourceClass)]);
     }
 
-    private function normalizeValue($value, string $property): ?bool
+    private function normalizeValue(mixed $value, string $property): ?bool
     {
         if (\in_array($value, [true, 'true', '1'], true)) {
             return true;

src/Doctrine/Common/Filter/DateFilterTrait.php

@@ -81,7 +81,7 @@ protected function getFilterDescription(string $property, string $period): array
         ];
     }
 
-    private function normalizeValue($value, string $operator): ?string
+    private function normalizeValue(mixed $value, string $operator): ?string
     {
         if (false === \is_string($value)) {
             $this->getLogger()->notice('Invalid filter ignored', [

src/Doctrine/Common/Filter/ExistsFilterTrait.php

@@ -70,7 +70,7 @@ abstract protected function getLogger(): LoggerInterface;
 
     abstract protected function normalizePropertyName(string $property): string;
 
-    private function normalizeValue($value, string $property): ?bool
+    private function normalizeValue(mixed $value, string $property): ?bool
     {
         if (\in_array($value, [true, 'true', '1', '', null], true)) {
             return true;

src/Doctrine/Common/Filter/NumericFilterTrait.php

@@ -79,7 +79,7 @@ protected function isNumericField(string $property, string $resourceClass): bool
         return isset(self::DOCTRINE_NUMERIC_TYPES[(string) $this->getDoctrineFieldType($property, $resourceClass)]);
     }
 
-    protected function normalizeValues($value, string $property): ?array
+    protected function normalizeValues(mixed $value, string $property): ?array
     {
         if (!is_numeric($value) && (!\is_array($value) || !$this->isNumericArray($value))) {
             $this->getLogger()->notice('Invalid filter ignored', [

src/Doctrine/Common/Filter/OrderFilterTrait.php

@@ -14,6 +14,7 @@
 namespace ApiPlatform\Doctrine\Common\Filter;
 
 use ApiPlatform\Doctrine\Common\PropertyHelperTrait;
+use ApiPlatform\Metadata\Exception\InvalidArgumentException;
 
 /**
  * Trait for ordering the collection by given properties.
@@ -70,13 +71,21 @@ abstract protected function getProperties(): ?array;
 
     abstract protected function normalizePropertyName(string $property): string;
 
-    private function normalizeValue($value, string $property): ?string
+    private function normalizeValue(mixed $value, string $property): ?string
     {
         if (empty($value) && null !== $defaultDirection = $this->getProperties()[$property]['default_direction'] ?? null) {
             // fallback to default direction
             $value = $defaultDirection;
         }
 
+        if (!\is_string($value)) {
+            $this->getLogger()->notice('Invalid filter ignored', [
+                'exception' => new InvalidArgumentException(\sprintf('Invalid string value for "%s" property', $property)),
+            ]);
+
+            return null;
+        }
+
         $value = strtoupper($value);
         if (!\in_array($value, [self::DIRECTION_ASC, self::DIRECTION_DESC], true)) {
             return null;

src/Doctrine/Common/State/PersistProcessor.php

@@ -110,7 +110,7 @@ public function process(mixed $data, Operation $operation, array $uriVariables =
     /**
      * Checks if doctrine does not manage data automatically.
      */
-    private function isDeferredExplicit(DoctrineObjectManager $manager, $data): bool
+    private function isDeferredExplicit(DoctrineObjectManager $manager, object $data): bool
     {
         $classMetadata = $manager->getClassMetadata($this->getObjectClass($data));
         if ($classMetadata && method_exists($classMetadata, 'isChangeTrackingDeferredExplicit')) { // @phpstan-ignore-line metadata can be null

src/Doctrine/Common/State/RemoveProcessor.php

@@ -40,7 +40,7 @@ public function process(mixed $data, Operation $operation, array $uriVariables =
     /**
      * Gets the Doctrine object manager associated with given data.
      */
-    private function getManager($data): ?DoctrineObjectManager
+    private function getManager(mixed $data): ?DoctrineObjectManager
     {
         return \is_object($data) ? $this->managerRegistry->getManagerForClass($this->getObjectClass($data)) : null;
     }

src/Doctrine/Odm/Filter/AbstractFilter.php

@@ -60,7 +60,7 @@ public function apply(Builder $aggregationBuilder, string $resourceClass, ?Opera
     /**
      * Passes a property through the filter.
      */
-    abstract protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void;
+    abstract protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void;
 
     public function hasManagerRegistry(): bool
     {