fix(symfony): fix property restrictions for root resource with dynamic validation groups (#6908)

Co-authored-by: soyuka <soyuka@users.noreply.github.com>

Author: c1tru55

src/Symfony/Validator/Metadata/Property/ValidatorPropertyMetadataFactory.php

@@ -151,7 +151,10 @@ public function create(string $resourceClass, string $property, array $options =
      */
     private function getValidationGroups(ValidatorClassMetadataInterface $classMetadata, array $options): array
     {
-        if (isset($options['validation_groups'])) {
+        if (
+            isset($options['validation_groups'])
+            && !\is_callable($options['validation_groups'])
+        ) {
             return $options['validation_groups'];
         }
 

tests/Fixtures/DummyValidatedEntity.php

@@ -77,4 +77,12 @@ class DummyValidatedEntity
      */
     #[Assert\Url]
     public $dummyUrl;
+
+    /**
+     * @return string[]
+     */
+    public static function getValidationGroups(): array
+    {
+        return ['dummy'];
+    }
 }

tests/Symfony/Validator/Metadata/Property/ValidatorPropertyMetadataFactoryTest.php

@@ -272,8 +272,8 @@ public function testCreateWithPropertyLengthRestriction(): void
 
         $validatorMetadataFactory = $this->prophesize(MetadataFactoryInterface::class);
         $validatorMetadataFactory->getMetadataFor(DummyValidatedEntity::class)
-                                 ->willReturn($validatorClassMetadata)
-                                 ->shouldBeCalled();
+            ->willReturn($validatorClassMetadata)
+            ->shouldBeCalled();
 
         $decoratedPropertyMetadataFactory = $this->prophesize(PropertyMetadataFactoryInterface::class);
         $property = 'dummy';
@@ -283,7 +283,9 @@ public function testCreateWithPropertyLengthRestriction(): void
 
         $lengthRestrictions = new PropertySchemaLengthRestriction();
         $validatorPropertyMetadataFactory = new ValidatorPropertyMetadataFactory(
-            $validatorMetadataFactory->reveal(), $decoratedPropertyMetadataFactory->reveal(), [$lengthRestrictions]
+            $validatorMetadataFactory->reveal(),
+            $decoratedPropertyMetadataFactory->reveal(),
+            [$lengthRestrictions]
         );
 
         $schema = $validatorPropertyMetadataFactory->create(DummyValidatedEntity::class, $property)->getSchema();
@@ -299,16 +301,17 @@ public function testCreateWithPropertyRegexRestriction(): void
 
         $validatorMetadataFactory = $this->prophesize(MetadataFactoryInterface::class);
         $validatorMetadataFactory->getMetadataFor(DummyValidatedEntity::class)
-                                 ->willReturn($validatorClassMetadata)
-                                 ->shouldBeCalled();
+            ->willReturn($validatorClassMetadata)
+            ->shouldBeCalled();
 
         $decoratedPropertyMetadataFactory = $this->prophesize(PropertyMetadataFactoryInterface::class);
         $decoratedPropertyMetadataFactory->create(DummyValidatedEntity::class, 'dummy', [])->willReturn(
             new ApiProperty()
         )->shouldBeCalled();
 
         $validationPropertyMetadataFactory = new ValidatorPropertyMetadataFactory(
-            $validatorMetadataFactory->reveal(), $decoratedPropertyMetadataFactory->reveal(),
+            $validatorMetadataFactory->reveal(),
+            $decoratedPropertyMetadataFactory->reveal(),
             [new PropertySchemaRegexRestriction()]
         );
 
@@ -326,8 +329,8 @@ public function testCreateWithPropertyFormatRestriction(string $property, string
 
         $validatorMetadataFactory = $this->prophesize(MetadataFactoryInterface::class);
         $validatorMetadataFactory->getMetadataFor($class)
-                                 ->willReturn($validatorClassMetadata)
-                                 ->shouldBeCalled();
+            ->willReturn($validatorClassMetadata)
+            ->shouldBeCalled();
 
         $decoratedPropertyMetadataFactory = $this->prophesize(PropertyMetadataFactoryInterface::class);
         $decoratedPropertyMetadataFactory->create($class, $property, [])->willReturn(
@@ -521,7 +524,8 @@ public function testCreateWithPropertyChoiceRestriction(ApiProperty $propertyMet
         )->shouldBeCalled();
 
         $validationPropertyMetadataFactory = new ValidatorPropertyMetadataFactory(
-            $validatorMetadataFactory->reveal(), $decoratedPropertyMetadataFactory->reveal(),
+            $validatorMetadataFactory->reveal(),
+            $decoratedPropertyMetadataFactory->reveal(),
             [new PropertySchemaChoiceRestriction()]
         );
 
@@ -558,7 +562,8 @@ public function testCreateWithPropertyCountRestriction(string $property, array $
         )->shouldBeCalled();
 
         $validationPropertyMetadataFactory = new ValidatorPropertyMetadataFactory(
-            $validatorMetadataFactory->reveal(), $decoratedPropertyMetadataFactory->reveal(),
+            $validatorMetadataFactory->reveal(),
+            $decoratedPropertyMetadataFactory->reveal(),
             [new PropertySchemaCountRestriction()]
         );
 
@@ -660,7 +665,8 @@ public function testCreateWithPropertyNumericRestriction(ApiProperty $propertyMe
         )->shouldBeCalled();
 
         $validationPropertyMetadataFactory = new ValidatorPropertyMetadataFactory(
-            $validatorMetadataFactory->reveal(), $decoratedPropertyMetadataFactory->reveal(),
+            $validatorMetadataFactory->reveal(),
+            $decoratedPropertyMetadataFactory->reveal(),
             [
                 new PropertySchemaGreaterThanOrEqualRestriction(),
                 new PropertySchemaGreaterThanRestriction(),
@@ -724,4 +730,22 @@ public static function provideNumericConstraintCases(): \Generator
             'expectedSchema' => ['maximum' => 0],
         ];
     }
+
+    public function testCallableGroup(): void
+    {
+        $propertyMetadata = (new ApiProperty())->withDescription('A dummy group')->withReadable(true)->withWritable(true);
+
+        $decoratedPropertyMetadataFactory = $this->prophesize(PropertyMetadataFactoryInterface::class);
+        $decoratedPropertyMetadataFactory->create(DummyValidatedEntity::class, 'dummyGroup', ['validation_groups' => [DummyValidatedEntity::class, 'getValidationGroups']])->willReturn($propertyMetadata)->shouldBeCalled();
+
+        $validatorMetadataFactory = $this->prophesize(MetadataFactoryInterface::class);
+        $validatorMetadataFactory->getMetadataFor(DummyValidatedEntity::class)->willReturn($this->validatorClassMetadata)->shouldBeCalled();
+
+        $validatorPropertyMetadataFactory = new ValidatorPropertyMetadataFactory(
+            $validatorMetadataFactory->reveal(),
+            $decoratedPropertyMetadataFactory->reveal(),
+            []
+        );
+        $validatorPropertyMetadataFactory->create(DummyValidatedEntity::class, 'dummyGroup', ['validation_groups' => [DummyValidatedEntity::class, 'getValidationGroups']]);
+    }
 }