Make sendAPN test independent of cexpired cert

Author: alex-friedl

.github/copilot-instructions.md

@@ -1,22 +1,26 @@
 # Copilot Instructions for AI Agents
 
 ## Project Overview
+
 This repository implements a Node.js module for sending push notifications across multiple platforms: Apple (APN), Google (GCM/FCM), Windows (WNS), Amazon (ADM), and Web-Push. The core logic is in `lib/` and `src/`, with each platform handled by a dedicated file (e.g., `sendAPN.js`, `sendFCM.js`).
 
 ## Architecture & Data Flow
+
 - **Entry Point:** Use `PushNotifications` from `lib/index.js` or `src/index.js`.
 - **Settings:** Each platform's credentials/config are passed to the constructor. See the example in `README.md`.
 - **Sending:** The main method is `push.send(registrationIds, data, callback)` or as a Promise. It auto-detects device type and routes to the correct sender.
 - **Platform Senders:** Each sender (e.g., `sendAPN.js`, `sendFCM.js`) implements the logic for its platform. Shared utilities are in `lib/utils/` and `src/utils/`.
 - **RegId Detection:** Device type is inferred from the registration ID structure. See `PN.getPushMethodByRegId` for details.
 
 ## Developer Workflows
+
 - **Install:** `npm install`
 - **Test:** Run all tests with `npm test`. Tests are in `test/` and cover basic flows and platform-specific cases.
 - **Debug:** Use the callback or Promise error/result from `push.send`. Each result object includes method, success/failure counts, and error details per device.
 - **Build:** No build step required for basic usage. ES6 is used, but compatible with ES5 via Babel if needed.
 
 ## Conventions & Patterns
+
 - **Platform-specific files:** Each push service has its own file for isolation and clarity.
 - **Unified Data Model:** The `data` object for notifications is normalized across platforms. See `README.md` for all supported fields.
 - **Error Handling:** Errors are unified and returned in the result array from `push.send`.
@@ -25,6 +29,7 @@ This repository implements a Node.js module for sending push notifications acros
 - **Constants:** Use constants from `constants.js` for platform types.
 
 ## Integration Points
+
 - **External Libraries:**
   - APN: `node-apn`
   - FCM: `firebase-admin`
@@ -35,12 +40,15 @@ This repository implements a Node.js module for sending push notifications acros
 - **Credentials:** Place service account keys and certificates in appropriate locations (see `README.md` for examples).
 
 ## Key Files & Directories
+
 - `lib/` and `src/`: Main implementation (mirrored structure)
 - `test/`: Test cases and sample credentials
 - `README.md`: Usage, configuration, and data model reference
 
 ## Example Usage
+
 See `README.md` for a full example of settings, registration ID formats, and sending notifications.
 
 ---
+
 For unclear or incomplete sections, please provide feedback or specify which workflows, patterns, or integrations need further documentation.

package-lock.json

@@ -53,8 +53,8 @@ describe('push-notifications: instantiation and class properties', () => {
           keyId: 'testKeyId',
           teamId: 'testTeamId',
         },
-        cert: path.resolve('test/send/cert.pem'),
-        key: path.resolve('test/send/key.pem'),
+        cert: 'some-file-path',
+        key: 'some-file-path',
       },
       wns: {
         client_id: 'client id',

test/push-notifications/basic.js

@@ -1,21 +1,38 @@
 /* eslint-env mocha */
-import path from 'path';
 import chai from 'chai';
 import sinon from 'sinon';
 import sinonChai from 'sinon-chai';
 import dirtyChai from 'dirty-chai';
-import { readFileSync } from 'fs';
 
 import apn from '@parse/node-apn';
 import PN from '../../src';
 import APN from '../../src/sendAPN';
+
 import {
   sendOkMethodGCM,
   testPushSuccess,
   testPushError,
   testPushException,
 } from '../util';
 
+// Mock apn certificate loading to prevent file access
+before(() => {
+  // Stub out the Provider constructor to avoid certificate loading
+  sinon.stub(apn, 'Provider', function mockProvider(options) {
+    this.client = { config: options };
+  });
+  // Ensure prototype methods exist for tests to stub
+  if (!apn.Provider.prototype.send) {
+    apn.Provider.prototype.send = () => {};
+  }
+  if (!apn.Provider.prototype.shutdown) {
+    apn.Provider.prototype.shutdown = () => {};
+  }
+});
+after(() => {
+  sinon.restore();
+});
+
 const { expect } = chai;
 chai.use(dirtyChai);
 chai.use(sinonChai);
@@ -36,12 +53,10 @@ const data = {
 };
 const experienceId = '43e798c-4dff073-2b58a85a-27c5d9fdf59-b69';
 const apnOptions = {
-  cert: path.resolve('./test/send/cert.pem'),
-  key: path.resolve('./test/send/key.pem'),
+  cert: 'DUMMY_CERT',
+  key: 'DUMMY_KEY',
 };
-const pn = new PN({
-  apn: apnOptions,
-});
+let pn;
 const fErr = new Error('Forced error');
 const errStatusCode = '410';
 
@@ -59,12 +74,12 @@ function sendOkMethod() {
     apn.Provider.prototype,
     'send',
     function sendAPN(message, _regIds) {
-      // TODO: validate other props? What about token?
+      // Validate config uses dummy cert/key
       expect(this.client.config)
         .to.be.an('object')
         .includes.keys(['cert', 'key']);
-      expect(this.client.config.cert).to.eql(readFileSync(apnOptions.cert));
-      expect(this.client.config.key).to.eql(readFileSync(apnOptions.key));
+      expect(this.client.config.cert).to.eql('DUMMY_CERT');
+      expect(this.client.config.key).to.eql('DUMMY_KEY');
 
       expect(_regIds).to.be.instanceOf(Array);
       _regIds.forEach((regId) => expect(regIds).to.include(regId));
@@ -131,6 +146,12 @@ function sendThrowExceptionMethod() {
 }
 
 describe('push-notifications-apn', () => {
+  before(() => {
+    pn = new PN({
+      apn: apnOptions,
+    });
+  });
+
   describe('send push notifications successfully', () => {
     before(() => {
       sendMethod = sendOkMethod();
@@ -718,10 +739,12 @@ describe('push-notifications-apn', () => {
   });
 
   describe('shutdown', () => {
-    const connectionStub = sinon.stub(apn.Provider.prototype, 'shutdown');
-    const apnInstance = new APN(apnOptions);
+    let connectionStub;
+    let apnInstance;
 
     before(() => {
+      connectionStub = sinon.stub(apn.Provider.prototype, 'shutdown');
+      apnInstance = new APN(apnOptions);
       apnInstance.shutdown();
     });