cleaned code

Author: rashtao

core/src/main/java/com/arangodb/internal/serde/InternalSerializers.java

@@ -30,7 +30,7 @@ public void serialize(RawJson value, JsonGenerator gen, SerializerProvider seria
         @Override
         public void serialize(RawBytes value, JsonGenerator gen, SerializerProvider serializers) throws IOException {
             // TODO: find a way to append raw bytes directly
-            // see https://github.com/FasterXML/jackson-dataformats-binary/issues/331
+            // see https://github.com/FasterXML/jackson-core/issues/914
             try (JsonParser parser = gen.getCodec().getFactory().createParser(value.get())) {
                 gen.writeTree(parser.readValueAsTree());
             }

core/src/main/java/com/arangodb/internal/serde/UserDataSerializer.java

@@ -17,7 +17,7 @@ class UserDataSerializer extends JsonSerializer<Object> {
     @Override
     public void serialize(Object value, JsonGenerator gen, SerializerProvider serializers) throws IOException {
         // TODO: find a way to append raw bytes directly
-        // see https://github.com/FasterXML/jackson-dataformats-binary/issues/331
+        // see https://github.com/FasterXML/jackson-core/issues/914
         try (JsonParser parser = gen.getCodec().getFactory().createParser(serde.serializeUserData(value))) {
             gen.writeTree(parser.readValueAsTree());
         }

core/src/main/java/com/arangodb/internal/util/ResponseUtils.java

@@ -42,26 +42,6 @@ private ResponseUtils() {
         super();
     }
 
-    // FIXME: remove
-    public static void checkError(final InternalSerde util, final InternalResponse response) {
-        final int responseCode = response.getResponseCode();
-        if (responseCode >= ERROR_STATUS) {
-            if (responseCode == ERROR_INTERNAL && response.containsMeta(HEADER_ENDPOINT)) {
-                throw new ArangoDBRedirectException(String.format("Response Code: %s", responseCode),
-                        response.getMeta(HEADER_ENDPOINT));
-            } else if (response.getBody() != null) {
-                final ErrorEntity errorEntity = util.deserialize(response.getBody(), ErrorEntity.class);
-                ArangoDBException e = new ArangoDBException(errorEntity);
-                if (ArangoErrors.QUEUE_TIME_VIOLATED.equals(e.getErrorNum())) {
-                    throw ArangoDBException.of(new TimeoutException().initCause(e));
-                }
-                throw e;
-            } else {
-                throw new ArangoDBException(String.format("Response Code: %s", responseCode), responseCode);
-            }
-        }
-    }
-
     public static ArangoDBException translateError(final InternalSerde util, final InternalResponse response) {
         final int responseCode = response.getResponseCode();
         if (responseCode >= ERROR_STATUS) {

driver/src/test/java/com/arangodb/ConcurrencyAsyncTests.java

@@ -19,19 +19,16 @@
 
 class ConcurrencyAsyncTests {
 
-    /**
-     * FIXME:   make the user executor configurable in com.arangodb.internal.ArangoExecutorAsync::execute
-     * (eg. this test passes using a CachedThreadPool)
-     */
-    @Disabled
     @ParameterizedTest
     @EnumSource(Protocol.class)
     @Timeout(2)
     void executorLimit(Protocol protocol) {
         ArangoDBAsync adb = new ArangoDB.Builder()
                 .loadProperties(ConfigUtils.loadConfig())
                 .maxConnections(1)
-                .protocol(protocol).build().async();
+                .protocol(protocol)
+                .asyncExecutor(Executors.newCachedThreadPool())
+                .build().async();
 
         List<CompletableFuture<ArangoDBVersion>> futures = IntStream.range(0, 20)
                 .mapToObj(i -> adb.getVersion()
@@ -64,6 +61,7 @@ void executorLimit(Protocol protocol) {
     void outgoingRequestsParallelismTest(Protocol protocol) {
         ArangoDBAsync adb = new ArangoDB.Builder()
                 .loadProperties(ConfigUtils.loadConfig())
+                .maxConnections(20)
                 .protocol(protocol).build().async();
 
         for (int i = 0; i < 50_000; i++) {

http/src/main/java/com/arangodb/http/HttpCommunication.java

@@ -121,7 +121,7 @@ private CompletableFuture<InternalResponse> executeAsync(final InternalRequest r
                             }
                         }
                     } catch (Exception ex) {
-                        rfuture.completeExceptionally(ex);
+                        rfuture.completeExceptionally(ArangoDBException.of(ex));
                     }
                 });
         return rfuture;

vst/src/main/java/com/arangodb/vst/VstCommunication.java

@@ -150,7 +150,8 @@ protected R execute(final InternalRequest request, final HostHandle hostHandle,
     protected abstract R execute(final InternalRequest request, C connection, final int attemptCount);
 
     protected void checkError(final InternalResponse response) {
-        ResponseUtils.checkError(serde, response);
+        ArangoDBException e = ResponseUtils.translateError(serde, response);
+        if (e != null) throw e;
     }
 
     protected InternalResponse createResponse(final Message message) throws VPackParserException {