[DE-969] deserialization passthrough for RawBytes and RawJson (#592)

* Serde: deserialization pass-through for RawJson and RawBytes

* test x-arango-dump content-type

Author: rashtao

core/src/main/java/com/arangodb/internal/serde/InternalSerde.java

@@ -130,15 +130,6 @@ default <T> T deserialize(byte[] content, String jsonPointer, Type type) {
      */
     <T> T deserializeUserData(byte[] content, JavaType clazz);
 
-    /**
-     * Deserializes the parsed json node and binds it to the target data type.
-     * The parser is not closed.
-     *
-     * @param parser json parser
-     * @param clazz  class of target data type
-     * @return deserialized object
-     */
-    <T> T deserializeUserData(JsonParser parser, JavaType clazz);
 
     /**
      * @param content byte array to deserialize

core/src/main/java/com/arangodb/internal/serde/InternalSerdeImpl.java

@@ -180,19 +180,6 @@ public <T> T deserializeUserData(byte[] content, JavaType clazz) {
         }
     }
 
-    @Override
-    public <T> T deserializeUserData(JsonParser parser, JavaType clazz) {
-        try {
-            if (SerdeUtils.isManagedClass(clazz.getRawClass())) {
-                return mapper.readerFor(clazz).readValue(parser);
-            } else {
-                return deserializeUserData(extractBytes(parser), clazz);
-            }
-        } catch (IOException e) {
-            throw ArangoDBException.of(e);
-        }
-    }
-
     @Override
     public boolean isDocument(byte[] content) {
         try (JsonParser p = mapper.getFactory().createParser(content)) {
@@ -240,14 +227,21 @@ public <T> T deserialize(final JsonNode node, final Type type) {
     }
 
     @Override
+    @SuppressWarnings("unchecked")
     public <T> T deserialize(final byte[] content, final Type type) {
         if (content == null || content.length == 0) {
             return null;
         }
-        try {
-            return mapper.readerFor(mapper.constructType(type)).readValue(content);
-        } catch (IOException e) {
-            throw ArangoDBException.of(e);
+        if (RawBytes.class.equals(type)) {
+            return (T) RawBytes.of(content);
+        } else if (RawJson.class.equals(type) && JsonFactory.FORMAT_NAME_JSON.equals(mapper.getFactory().getFormatName())) {
+            return (T) RawJson.of(new String(content, StandardCharsets.UTF_8));
+        } else {
+            try {
+                return mapper.readerFor(mapper.constructType(type)).readValue(content);
+            } catch (IOException e) {
+                throw ArangoDBException.of(e);
+            }
         }
     }
 

test-resilience/src/test/java/resilience/mock/SerdeTest.java

@@ -2,7 +2,10 @@
 
 import ch.qos.logback.classic.Level;
 import com.arangodb.ArangoDBException;
+import com.arangodb.Request;
+import com.arangodb.Response;
 import com.arangodb.entity.MultiDocumentEntity;
+import com.arangodb.util.RawJson;
 import com.fasterxml.jackson.core.JsonParseException;
 import com.fasterxml.jackson.databind.JsonNode;
 import org.junit.jupiter.api.Test;
@@ -133,4 +136,31 @@ void getDocumentsWithErrorField() {
                 .anySatisfy(d -> assertThat(d.get("_key").textValue()).isEqualTo("2"))
                 .anySatisfy(d -> assertThat(d.get("_key").textValue()).isEqualTo("3"));
     }
+
+    @Test
+    void getXArangoDumpJsonLines() {
+        String resp = "{\"a\":1}\n" +
+                "{\"b\":2}\n" +
+                "{\"c\":3}";
+
+        mockServer
+                .when(
+                        request()
+                                .withMethod("GET")
+                                .withPath("/_db/foo/_api/foo")
+                )
+                .respond(
+                        response()
+                                .withStatusCode(200)
+                                .withHeader("Content-Type", "application/x-arango-dump; charset=utf-8")
+                                .withBody(resp.getBytes(StandardCharsets.UTF_8))
+                );
+
+        Response<RawJson> res = arangoDB.execute(Request.builder()
+                .method(Request.Method.GET)
+                .db("foo")
+                .path("/_api/foo")
+                .build(), RawJson.class);
+        assertThat(res.getBody().get()).endsWith("{\"c\":3}");
+    }
 }