Skip to content

Commit f177b95

Browse files
authored
review supported property types (#14)
* review supported property types * fixed DataTypesTest
1 parent d4e66c1 commit f177b95

File tree

4 files changed

+20
-22
lines changed

4 files changed

+20
-22
lines changed

README.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -528,24 +528,24 @@ This library supports the following features:
528528
>-- ServiceCall: false
529529
> VariableFeatures
530530
>-- Variables: true
531+
>-- LongArrayValues: true
532+
>-- StringArrayValues: true
531533
>-- BooleanValues: true
532534
>-- ByteValues: false
533535
>-- DoubleValues: true
534536
>-- FloatValues: false
535537
>-- IntegerValues: true
536538
>-- LongValues: true
537-
>-- MapValues: false
538-
>-- MixedListValues: false
539+
>-- MapValues: true
540+
>-- MixedListValues: true
539541
>-- SerializableValues: false
540542
>-- StringValues: true
541-
>-- UniformListValues: false
543+
>-- UniformListValues: true
542544
>-- BooleanArrayValues: true
543545
>-- ByteArrayValues: false
544546
>-- DoubleArrayValues: true
545547
>-- FloatArrayValues: false
546548
>-- IntegerArrayValues: true
547-
>-- LongArrayValues: true
548-
>-- StringArrayValues: true
549549
> VertexFeatures
550550
>-- DuplicateMultiProperties: false
551551
>-- AddVertices: true
@@ -572,24 +572,24 @@ This library supports the following features:
572572
>-- CustomIds: true
573573
>-- AnyIds: false
574574
>-- Properties: true
575+
>-- LongArrayValues: true
576+
>-- StringArrayValues: true
575577
>-- BooleanValues: true
576578
>-- ByteValues: false
577579
>-- DoubleValues: true
578580
>-- FloatValues: false
579581
>-- IntegerValues: true
580582
>-- LongValues: true
581-
>-- MapValues: false
582-
>-- MixedListValues: false
583+
>-- MapValues: true
584+
>-- MixedListValues: true
583585
>-- SerializableValues: false
584586
>-- StringValues: true
585-
>-- UniformListValues: false
587+
>-- UniformListValues: true
586588
>-- BooleanArrayValues: true
587589
>-- ByteArrayValues: false
588590
>-- DoubleArrayValues: true
589591
>-- FloatArrayValues: false
590592
>-- IntegerArrayValues: true
591-
>-- LongArrayValues: true
592-
>-- StringArrayValues: true
593593
> EdgeFeatures
594594
>-- Upsert: false
595595
>-- AddEdges: true
@@ -605,24 +605,24 @@ This library supports the following features:
605605
>-- AnyIds: false
606606
> EdgePropertyFeatures
607607
>-- Properties: true
608+
>-- LongArrayValues: true
609+
>-- StringArrayValues: true
608610
>-- BooleanValues: true
609611
>-- ByteValues: false
610612
>-- DoubleValues: true
611613
>-- FloatValues: false
612614
>-- IntegerValues: true
613615
>-- LongValues: true
614-
>-- MapValues: false
615-
>-- MixedListValues: false
616+
>-- MapValues: true
617+
>-- MixedListValues: true
616618
>-- SerializableValues: false
617619
>-- StringValues: true
618-
>-- UniformListValues: false
620+
>-- UniformListValues: true
619621
>-- BooleanArrayValues: true
620622
>-- ByteArrayValues: false
621623
>-- DoubleArrayValues: true
622624
>-- FloatArrayValues: false
623625
>-- IntegerArrayValues: true
624-
>-- LongArrayValues: true
625-
>-- StringArrayValues: true
626626
```
627627

628628
## Current Limitations

src/main/java/com/arangodb/tinkerpop/gremlin/structure/ArangoDBGraphFeatures.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,12 @@ public boolean supportsFloatValues() {
6363

6464
@Override
6565
public boolean supportsMapValues() {
66-
return false;
66+
return true;
6767
}
6868

6969
@Override
7070
public boolean supportsMixedListValues() {
71-
return false;
71+
return true;
7272
}
7373

7474
@Override
@@ -88,7 +88,7 @@ public boolean supportsSerializableValues() {
8888

8989
@Override
9090
public boolean supportsUniformListValues() {
91-
return false;
91+
return true;
9292
}
9393
}
9494

src/main/java/com/arangodb/tinkerpop/gremlin/utils/ArangoDBUtil.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@ private static boolean supportsDataType(Object value) {
8080
value instanceof Double || value instanceof double[] ||
8181
value instanceof Integer || value instanceof int[] ||
8282
value instanceof Long || value instanceof long[] ||
83-
value instanceof String || value instanceof String[];
83+
value instanceof String || value instanceof String[] ||
84+
value instanceof Collection || value instanceof Map;
8485
}
8586

8687
public static void checkVersion(String version) {

src/test/java/com/arangodb/tinkerpop/gremlin/arangodb/simple/DataTypesTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ public class DataTypesTest extends AbstractGremlinTest {
4242
);
4343

4444
private final List<?> unsupportedData = Arrays.asList(
45-
Collections.singletonMap("hello", "world"),
46-
Collections.singletonList("hello"),
47-
Collections.singleton("hello"),
4845
new Date(),
4946
new java.sql.Date(new Date().getTime()),
5047
new Date[]{new Date()},

0 commit comments

Comments
 (0)