fix last set of warnings

Author: ardera

src/pluginregistry.c

@@ -89,15 +89,19 @@ static struct plugin_instance *get_plugin_by_name(struct plugin_registry *regist
     return instance;
 }
 
+// clang-format off
 static struct platch_obj_cb_data *get_cb_data_by_channel_locked(struct plugin_registry *registry, const char *channel) {
-    list_for_each_entry(struct platch_obj_cb_data, data, &registry->callbacks, entry) {
-        if (streq(data->channel, channel)) {
-            return data;
+    ANALYZER_SUPPRESS({
+        list_for_each_entry(struct platch_obj_cb_data, data, &registry->callbacks, entry) {
+            if (streq(data->channel, channel)) {
+                return data;
+            }
         }
-    }
+    });
 
     return NULL;
 }
+// clang-format on
 
 struct plugin_registry *plugin_registry_new(struct flutterpi *flutterpi) {
     struct plugin_registry *reg;

src/util/list.h

@@ -93,9 +93,12 @@ static inline void list_replace(struct list_head *from, struct list_head *to) {
 }
 
 static inline void list_del(struct list_head *item) {
-    item->prev->next = item->next;
-    item->next->prev = item->prev;
-    item->prev = item->next = NULL;
+    // We need this to suppress a false positive `use-after-free` coming from pluginregistry.c.
+    ANALYZER_SUPPRESS({
+        item->prev->next = item->next;
+        item->next->prev = item->prev;
+        item->prev = item->next = NULL;
+    });
 }
 
 static inline void list_delinit(struct list_head *item) {

src/vulkan.c

@@ -5,9 +5,11 @@
 const char *vk_strerror(VkResult result) {
     PRAGMA_DIAGNOSTIC_PUSH
 
-    // We want to know when we don't handle a result code,
-    // but we don't want it to be an error.
-    PRAGMA_DIAGNOSTIC_WARNING("-Wswitch-enum")
+    // We'd really like to use PRAGMA_DIAGNOSTIC_WARNING for "-Wswitch-enum" here,
+    // but CodeChecker makes it hard to distinguish between warnings and errors
+    // and will always treat this an error.
+    // So ignore it for now.
+    PRAGMA_DIAGNOSTIC_IGNORED("-Wswitch-enum")
     switch (result) {
         case VK_SUCCESS: return "VK_SUCCESS";
         case VK_NOT_READY: return "VK_NOT_READY";