- cleanup and checks for connection member when required

Author: ubidefeo

src/ArduinoIoTCloud.cpp

@@ -77,7 +77,12 @@ int ArduinoIoTCloudClass::begin(Client& net, String brokerAddress)
   if (_bearSslClient) {
     delete _bearSslClient;
   }
-  _bearSslClient = new BearSSLClient(connection->getClient());
+  if(connection != NULL){
+    _bearSslClient = new BearSSLClient(connection->getClient());
+  }else{
+    _bearSslClient = new BearSSLClient(net);
+  }
+  
   _bearSslClient->setEccSlot(keySlot, ECCX08Cert.bytes(), ECCX08Cert.length());
   _mqttClient = new MqttClient(*_bearSslClient);
 

src/ConnectionManager.h

@@ -44,6 +44,7 @@ class ConnectionManager {
 // ms to wait between each retry
 #define NETWORK_LAYER_RECONNECTION_TIMEOUT 2000
 
+// TODO: remove references to ArduinoIoTCloud
 // ********** CLOUD LAYER *********** 
 // max arduino cloud connection retries
 #define ARDUINO_IOT_CLOUD_CONNECTION_RETRIES 30
@@ -82,6 +83,7 @@ class ConnectionManager {
 #define NETWORK_CONNECTED GSM3_NetworkStatus_t::GPRS_READY
 #endif
 
+// TODO: remove references to ArduinoIoTCloud
 #include <ArduinoIoTCloud.h>
 
 inline void debugMessage(char *_msg, uint8_t _debugLevel) {

src/WiFiConnectionManager.h

@@ -9,9 +9,11 @@ class WiFiConnectionManager : public ConnectionManager {
   virtual void init();
   virtual void check();
   virtual Client &getClient() { return wifiClient; };
+  // TODO: remove references to ArduinoIoTCloud
   virtual ArduinoIoTConnectionStatus status() { return IOT_STATUS_IDLE; };
 
 private:
+  // TODO: remove references to ArduinoIoTCloud
   void iotConnectionCheck();
   void changeConnectionState(NetworkConnectionState _newState);