-
Notifications
You must be signed in to change notification settings - Fork 1
feat: check pin G13 for host boot complete #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: check pin G13 for host boot complete #32
Conversation
|
Maybe we should consider extracting this from |
|
@sebromero I understand your point, but I have mixed feelings about it. |
|
@eigen-value What if we do the following: |
|
Hi @sebromero, @pennam Before marking the PR as ready I need to check If G13 is raised from a specific RC onward and if a timeout is needed for backwards compat |
sebromero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong but I think ready also needs to call init, otherwise mpu_boot_pin won't be configured correctly if ready is being called standalone. The mutex wouldn't necessarily be required by ready, so maybe the pin needs its own init function?
|
Memory usage change @ 1b14cf9
Click for full report table
Click for full report CSV |
No description provided.