unoq: fix: reversed A4 and A5 ADC channels and clarify pin assignments #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the io-channels ordering so that A4 maps to PC1 (ADC1 Channel 2) and A5 maps to PC0 (ADC1 Channel 1). The corresponding channels can be found in the STM datasheet on page 111. Also, add some comments to clarify which pins are being used.
|
|
facchinm
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the analog inputs on the Uno Q, I discovered that A4 and A5 were swapped in the device tree overlay. The corresponding channels can be found in the STM datasheet on page 111.
This took me a while to figure out because they were working perfectly when used as digital inputs. The error only appeared when I used them as ADC inputs.
I also added comments clarifying that the ADC lines refer to the A4 and A5 pins and their corresponding ports.